Re: [RESEND PATCH] pwm-backlight: fix the panel power sequence

From	YH Huang <yh.huang@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH] pwm-backlight: fix the panel power sequence
Date	2015-10-16 11:00 +0200
Message-ID	<qk91M-1e0-1@gated-at.bofh.it> (permalink)
References	<qk29X-7UD-5@gated-at.bofh.it> <qk8Iq-QV-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2015-10-16 at 10:36 +0200, Sascha Hauer wrote:
> On Fri, Oct 16, 2015 at 09:37:34AM +0800, YH Huang wrote:
> > In order to match the panel power sequence, disable the enable_gpio
> > in the probe function. Also, reorder the code in the power_on and
> > power_off function to match the timing.
> > @@ -241,8 +242,7 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> >  	pb->dev = &pdev->dev;
> >  	pb->enabled = false;
> >  
> > -	pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable",
> > -						  GPIOD_OUT_HIGH);
> > +	pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable");
> 
> Please actually test your patches. This change here won't compile.
> 
> Sascha
> 

I will send patch v2 to fix it.

YH Huang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND PATCH] pwm-backlight: fix the panel power sequence YH Huang <yh.huang@mediatek.com> - 2015-10-16 03:40 +0200
  Re: [RESEND PATCH] pwm-backlight: fix the panel power sequence Lucas Stach <l.stach@pengutronix.de> - 2015-10-16 10:40 +0200
  Re: [RESEND PATCH] pwm-backlight: fix the panel power sequence Sascha Hauer <s.hauer@pengutronix.de> - 2015-10-16 10:40 +0200
    Re: [RESEND PATCH] pwm-backlight: fix the panel power sequence YH Huang <yh.huang@mediatek.com> - 2015-10-16 11:00 +0200

csiph-web