Re: [PATCH 0/1] kmod: don't run async usermode helper as a child of kworker thread

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/1] kmod: don't run async usermode helper as a child of kworker thread
Date	2015-10-15 20:00 +0200
Message-ID	<qjUYP-5it-31@gated-at.bofh.it> (permalink)
References	(1 earlier) <qjS0W-Yf-15@gated-at.bofh.it> <qjS0W-Yf-13@gated-at.bofh.it> <qjT6H-2yx-23@gated-at.bofh.it> <qjTJo-3xl-27@gated-at.bofh.it> <qjU2K-3Ul-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/15, Frederic Weisbecker wrote:
>
> On Thu, Oct 15, 2015 at 06:32:17PM +0200, Oleg Nesterov wrote:
> >
> > But I would like to keep "we do not want to pollute current->children"
> > because this the goal of the next cleanups.
>
> I don't mind it, it's just that it's not obvious _why_ we don't want to
> pollute it.

Well, this connects to the "Note:" part of the changelog, I don't
this the comment can really explain this.

But note that this fix is not enough in the long term _unless_ we
ensure that another workueue callback can not call kernel_thread()
without CLONE_PARENT. And this is what I am going to do.

Nevermind, this is (almost) off-topic right now. Please review V2
I'll send in a minute, I tried to update the comment/changelog.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/1] Revert "kmod: handle UMH_WAIT_PROC from system unbound  workqueue" Oleg Nesterov <oleg@redhat.com> - 2015-10-14 21:00 +0200
  Re: [PATCH 0/1] kmod: don't run async usermode helper as a child  of kworker thread Oleg Nesterov <oleg@redhat.com> - 2015-10-15 16:50 +0200
    Re: [PATCH 0/1] kmod: don't run async usermode helper as a child of  kworker thread Frederic Weisbecker <fweisbec@gmail.com> - 2015-10-15 18:00 +0200
      Re: [PATCH 0/1] kmod: don't run async usermode helper as a child  of kworker thread Oleg Nesterov <oleg@redhat.com> - 2015-10-15 18:40 +0200
        Re: [PATCH 0/1] kmod: don't run async usermode helper as a child of  kworker thread Frederic Weisbecker <fweisbec@gmail.com> - 2015-10-15 19:00 +0200
          Re: [PATCH 0/1] kmod: don't run async usermode helper as a child  of kworker thread Oleg Nesterov <oleg@redhat.com> - 2015-10-15 20:00 +0200
  [PATCH 0/1] kmod: don't run async usermode helper as a child of  kworker thread Oleg Nesterov <oleg@redhat.com> - 2015-10-15 16:50 +0200
    [PATCH v2 1/1] kmod: don't run async usermode helper as a child of  kworker thread Oleg Nesterov <oleg@redhat.com> - 2015-10-15 20:00 +0200

csiph-web