Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1247862

[PATCH 0/1] kmod: don't run async usermode helper as a child of kworker thread

Show all headers | View raw

Andrew, please drop

	revert-kmod-handle-umh_wait_proc-from-system-unbound-workqueue.patch

I sent yesterday. On a second thought we have a better solution.

On 10/14, Oleg Nesterov wrote:
>
> Hello,
>
> I noticed by accident the kworker zombies on my testing machine.
> Can't reproduce (although I think it won't be hard to make a
> test-case), but I think the reason is clear, see the changelog.
>
> We could fix this by using kthread_create() if !UMH_WAIT_PROC,
> but imo it would be better to revert this change at least for
> now.

I changed my mind. I was worried about other workqueue callbacks
which could abuse kernel_thread() and populate kworker->children
even if we change call_usermodehelper_exec_work() to not do this.

But according to git-grep nobody does this. And this is good!
Because we can do more cleanups (will try to send "soon") to
ensure that all kthreads have parent == kthreadd.

And since the worker thread is already its child, we do not need
kthread_create(), we can just use CLONE_PARENT (which should be
later used by kernel_thread() by default).

> If we really want to avoid the extra kernel_thread(), we
> can make another patch which also avoids sys_wait4() and the
> games with SIGCHLD; we can rely on wait_chldexit.

Yes, this probably makes sense too, but we can do this regardless.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/1] Revert "kmod: handle UMH_WAIT_PROC from system unbound  workqueue" Oleg Nesterov <oleg@redhat.com> - 2015-10-14 21:00 +0200
  Re: [PATCH 0/1] kmod: don't run async usermode helper as a child  of kworker thread Oleg Nesterov <oleg@redhat.com> - 2015-10-15 16:50 +0200
    Re: [PATCH 0/1] kmod: don't run async usermode helper as a child of  kworker thread Frederic Weisbecker <fweisbec@gmail.com> - 2015-10-15 18:00 +0200
      Re: [PATCH 0/1] kmod: don't run async usermode helper as a child  of kworker thread Oleg Nesterov <oleg@redhat.com> - 2015-10-15 18:40 +0200
        Re: [PATCH 0/1] kmod: don't run async usermode helper as a child of  kworker thread Frederic Weisbecker <fweisbec@gmail.com> - 2015-10-15 19:00 +0200
          Re: [PATCH 0/1] kmod: don't run async usermode helper as a child  of kworker thread Oleg Nesterov <oleg@redhat.com> - 2015-10-15 20:00 +0200
  [PATCH 0/1] kmod: don't run async usermode helper as a child of  kworker thread Oleg Nesterov <oleg@redhat.com> - 2015-10-15 16:50 +0200
    [PATCH v2 1/1] kmod: don't run async usermode helper as a child of  kworker thread Oleg Nesterov <oleg@redhat.com> - 2015-10-15 20:00 +0200

csiph-web