Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1247842

Re: [PATCH] VFIO: platform: AMD xgbe reset module

Show all headers | View raw

On Thursday 15 October 2015 16:20:46 Eric Auger wrote:
> On 10/15/2015 02:12 PM, Christoffer Dall wrote:
> > On Thu, Oct 15, 2015 at 01:21:55PM +0200, Arnd Bergmann wrote:
> >> On Thursday 15 October 2015 10:08:02 Eric Auger wrote:
> >>> On 10/14/2015 05:38 PM, Arnd Bergmann wrote:
> >>>> On Wednesday 14 October 2015 15:33:12 Eric Auger wrote:
> >> A possible solution could be something inside the xgbe driver like
> >>
> >>
> >> static void xgbe_init_module(void)
> >> {
> >> 	int ret = 0;
> >>
> >> 	if (IS_ENABLED(CONFIG_AMD_XGBE_ETHERNET)
> >> 		ret = platform_driver_register(&xgbe_driver);
> >> 	if (ret)
> >> 		return ret;
> >>
> >> 	if (IS_ENABLED(CONFIG_VFIO_PLATFORM))
> >> 		ret = vfio_platform_register_reset(&xgbe_of_match, xgbe_platform_reset);
> >>
> >> 	return ret;	
> >> }
> >>
> >> This way you have exactly one driver module that gets loaded for the
> >> device and you can use it either with the platform_driver or through
> >> vfio.
> If I understand it correctly you still need 2 loaded modules (VFIO
> driver & XGBE driver which implements the reset function) or am I
> missing something?

That is correct, yes.
 
> I had a similar mechanism of registration in my PATCH v1 but I did the
> registration from the reset module itself instead of in the native
> driver, as you suggest here.

Right. The main difference is that you don't have two modules fighting
over the same device with the approach here.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] VFIO: platform: AMD xgbe reset module Eric Auger <eric.auger@linaro.org> - 2015-10-14 17:40 +0200
  Re: [PATCH] VFIO: platform: AMD xgbe reset module Arnd Bergmann <arnd@arndb.de> - 2015-10-14 17:40 +0200
    Re: [PATCH] VFIO: platform: AMD xgbe reset module Eric Auger <eric.auger@linaro.org> - 2015-10-15 10:10 +0200
      Re: [PATCH] VFIO: platform: AMD xgbe reset module Arnd Bergmann <arnd@arndb.de> - 2015-10-15 13:30 +0200
        Re: [PATCH] VFIO: platform: AMD xgbe reset module Christoffer Dall <christoffer.dall@linaro.org> - 2015-10-15 14:20 +0200
          Re: [PATCH] VFIO: platform: AMD xgbe reset module Arnd Bergmann <arnd@arndb.de> - 2015-10-15 16:10 +0200
            Re: [PATCH] VFIO: platform: AMD xgbe reset module Eric Auger <eric.auger@linaro.org> - 2015-10-15 16:50 +0200
              Re: [PATCH] VFIO: platform: AMD xgbe reset module Arnd Bergmann <arnd@arndb.de> - 2015-10-15 17:00 +0200
                Re: [PATCH] VFIO: platform: AMD xgbe reset module Christoffer Dall <christoffer.dall@linaro.org> - 2015-10-15 17:10 +0200
                Re: [PATCH] VFIO: platform: AMD xgbe reset module Arnd Bergmann <arnd@arndb.de> - 2015-10-15 18:00 +0200
                Re: [PATCH] VFIO: platform: AMD xgbe reset module Christoffer Dall <christoffer.dall@linaro.org> - 2015-10-15 18:40 +0200
              Re: [PATCH] VFIO: platform: AMD xgbe reset module Alex Williamson <alex.williamson@redhat.com> - 2015-10-15 19:00 +0200
                Re: [PATCH] VFIO: platform: AMD xgbe reset module Christoffer Dall <christoffer.dall@linaro.org> - 2015-10-15 21:50 +0200
                Re: [PATCH] VFIO: platform: AMD xgbe reset module Alex Williamson <alex.williamson@redhat.com> - 2015-10-15 22:30 +0200
                Re: [PATCH] VFIO: platform: AMD xgbe reset module Eric Auger <eric.auger@linaro.org> - 2015-10-16 15:10 +0200
                Re: [PATCH] VFIO: platform: AMD xgbe reset module Arnd Bergmann <arnd@arndb.de> - 2015-10-16 15:30 +0200
                Re: [PATCH] VFIO: platform: AMD xgbe reset module Eric Auger <eric.auger@linaro.org> - 2015-10-16 16:00 +0200
          Re: [PATCH] VFIO: platform: AMD xgbe reset module Arnd Bergmann <arnd@arndb.de> - 2015-10-15 16:30 +0200
          Re: [PATCH] VFIO: platform: AMD xgbe reset module Eric Auger <eric.auger@linaro.org> - 2015-10-15 16:30 +0200

csiph-web