Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1247543

Re: [PATCH] VFIO: platform: AMD xgbe reset module

Show all headers | View raw

Hi Arnd,
On 10/14/2015 05:38 PM, Arnd Bergmann wrote:
> On Wednesday 14 October 2015 15:33:12 Eric Auger wrote:
>> --- a/drivers/vfio/platform/vfio_platform_common.c
>> +++ b/drivers/vfio/platform/vfio_platform_common.c
>> @@ -31,6 +31,11 @@ static const struct vfio_platform_reset_combo reset_lookup_table[] = {
>>                 .reset_function_name = "vfio_platform_calxedaxgmac_reset",
>>                 .module_name = "vfio-platform-calxedaxgmac",
>>         },
>> +       {
>> +               .compat = "amd,xgbe-seattle-v1a",
>> +               .reset_function_name = "vfio_platform_amdxgbe_reset",
>> +               .module_name = "vfio-platform-amdxgbe",
>> +       },
>>  };
>>  
>>  static void vfio_platform_get_reset(struct vfio_platform_device *vdev,
>>
> 
> This is causing build errors for me when CONFIG_MODULES is disabled.
Sorry about that and thanks for reporting the issue
> 
> Could this please be restructured so vfio_platform_get_reset does
> not attempt to call __symbol_get() but instead has the drivers
> register themselves properly to a subsystem?
OK

Could you elaborate about "has the drivers register themselves properly
to a subsystem".

My first proposal when coping with this problematic of being able to add
reset plugins to the vfio-platform driver was to create new drivers per
device requiring reset. but this was considered painful for end-users,
who needed to be aware of the right driver to bind - and I think that
makes sense - (https://lkml.org/lkml/2015/4/17/568) .

A naive question I dare to ask, wouldn't it be acceptable to make
vfio_platform depend on CONFIG_MODULES? Don't we disable modules for
security purpose? In that context would we use VFIO?

Best Regards

Eric
> 
> I don't see any way this could be fixed otherwise. The problem
> of course showed up with calxedaxgmac already, but I'd prefer not
> to see anything added there until the common code has been improved.
> 
> 	Arnd
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] VFIO: platform: AMD xgbe reset module Eric Auger <eric.auger@linaro.org> - 2015-10-14 17:40 +0200
  Re: [PATCH] VFIO: platform: AMD xgbe reset module Arnd Bergmann <arnd@arndb.de> - 2015-10-14 17:40 +0200
    Re: [PATCH] VFIO: platform: AMD xgbe reset module Eric Auger <eric.auger@linaro.org> - 2015-10-15 10:10 +0200
      Re: [PATCH] VFIO: platform: AMD xgbe reset module Arnd Bergmann <arnd@arndb.de> - 2015-10-15 13:30 +0200
        Re: [PATCH] VFIO: platform: AMD xgbe reset module Christoffer Dall <christoffer.dall@linaro.org> - 2015-10-15 14:20 +0200
          Re: [PATCH] VFIO: platform: AMD xgbe reset module Arnd Bergmann <arnd@arndb.de> - 2015-10-15 16:10 +0200
            Re: [PATCH] VFIO: platform: AMD xgbe reset module Eric Auger <eric.auger@linaro.org> - 2015-10-15 16:50 +0200
              Re: [PATCH] VFIO: platform: AMD xgbe reset module Arnd Bergmann <arnd@arndb.de> - 2015-10-15 17:00 +0200
                Re: [PATCH] VFIO: platform: AMD xgbe reset module Christoffer Dall <christoffer.dall@linaro.org> - 2015-10-15 17:10 +0200
                Re: [PATCH] VFIO: platform: AMD xgbe reset module Arnd Bergmann <arnd@arndb.de> - 2015-10-15 18:00 +0200
                Re: [PATCH] VFIO: platform: AMD xgbe reset module Christoffer Dall <christoffer.dall@linaro.org> - 2015-10-15 18:40 +0200
              Re: [PATCH] VFIO: platform: AMD xgbe reset module Alex Williamson <alex.williamson@redhat.com> - 2015-10-15 19:00 +0200
                Re: [PATCH] VFIO: platform: AMD xgbe reset module Christoffer Dall <christoffer.dall@linaro.org> - 2015-10-15 21:50 +0200
                Re: [PATCH] VFIO: platform: AMD xgbe reset module Alex Williamson <alex.williamson@redhat.com> - 2015-10-15 22:30 +0200
                Re: [PATCH] VFIO: platform: AMD xgbe reset module Eric Auger <eric.auger@linaro.org> - 2015-10-16 15:10 +0200
                Re: [PATCH] VFIO: platform: AMD xgbe reset module Arnd Bergmann <arnd@arndb.de> - 2015-10-16 15:30 +0200
                Re: [PATCH] VFIO: platform: AMD xgbe reset module Eric Auger <eric.auger@linaro.org> - 2015-10-16 16:00 +0200
          Re: [PATCH] VFIO: platform: AMD xgbe reset module Arnd Bergmann <arnd@arndb.de> - 2015-10-15 16:30 +0200
          Re: [PATCH] VFIO: platform: AMD xgbe reset module Eric Auger <eric.auger@linaro.org> - 2015-10-15 16:30 +0200

csiph-web