Re: [PATCH 4/5] x86/setup/crash: Check memblock_reserve() retval

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/5] x86/setup/crash: Check memblock_reserve() retval
Date	2015-10-15 12:10 +0200
Message-ID	<qjNE0-3cO-31@gated-at.bofh.it> (permalink)
References	<qjM5c-QH-7@gated-at.bofh.it> <qjM5c-QH-21@gated-at.bofh.it> <qjN1g-2cP-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Oct 15, 2015 at 05:18:26PM +0800, Dave Young wrote:
> Seems there's no checking for other callback to memblock_reserve in setup.c
> Need another cleanup?

True story. It sure does.

> BTW, a further cleanup is reasonable to me, there's a lot of below patter:
> memblock_find_in_range
> error checking
> memblock_reserve
> error checking
> 
> So a new function memblock_reserve_in_range is reasonable.

Well, in some of the callsites, the first "error checking" issues
a specific message, depending on the subsystem. The following
memblock_reserve() is mostly unchecked though. At least that should be
fixed...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/5] x86/setup/crash: Check memblock_reserve() retval Borislav Petkov <bp@alien8.de> - 2015-10-15 10:30 +0200
  Re: [PATCH 4/5] x86/setup/crash: Check memblock_reserve() retval Dave Young <dyoung@redhat.com> - 2015-10-15 11:30 +0200
    Re: [PATCH 4/5] x86/setup/crash: Check memblock_reserve() retval Borislav Petkov <bp@alien8.de> - 2015-10-15 12:10 +0200

csiph-web