Re: [PATCH v8 2/9] Input: goodix - reset device at init

From	kbuild test robot <lkp@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 2/9] Input: goodix - reset device at init
Date	2015-10-11 01:40 +0200
Message-ID	<qibU6-7vg-9@gated-at.bofh.it> (permalink)
References	<qhkwq-6iy-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Irina,

[auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore]

config: x86_64-randconfig-h0-10110617 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/input/touchscreen/goodix.c: In function 'goodix_int_sync':
>> drivers/input/touchscreen/goodix.c:250:10: error: implicit declaration of function 'gpiod_direction_output' [-Werror=implicit-function-declaration]
     error = gpiod_direction_output(ts->gpiod_int, 0);
             ^
>> drivers/input/touchscreen/goodix.c:255:9: error: implicit declaration of function 'gpiod_direction_input' [-Werror=implicit-function-declaration]
     return gpiod_direction_input(ts->gpiod_int);
            ^
   drivers/input/touchscreen/goodix.c: In function 'goodix_get_gpio_config':
>> drivers/input/touchscreen/goodix.c:304:10: error: implicit declaration of function 'devm_gpiod_get' [-Werror=implicit-function-declaration]
     gpiod = devm_gpiod_get(dev, GOODIX_GPIO_INT_NAME, GPIOD_IN);
             ^
>> drivers/input/touchscreen/goodix.c:304:52: error: 'GPIOD_IN' undeclared (first use in this function)
     gpiod = devm_gpiod_get(dev, GOODIX_GPIO_INT_NAME, GPIOD_IN);
                                                       ^
   drivers/input/touchscreen/goodix.c:304:52: note: each undeclared identifier is reported only once for each function it appears in
   cc1: some warnings being treated as errors

vim +/gpiod_direction_output +250 drivers/input/touchscreen/goodix.c

   244	}
   245	
   246	static int goodix_int_sync(struct goodix_ts_data *ts)
   247	{
   248		int error;
   249	
 > 250		error = gpiod_direction_output(ts->gpiod_int, 0);
   251		if (error)
   252			return error;
   253		msleep(50);				/* T5: 50ms */
   254	
 > 255		return gpiod_direction_input(ts->gpiod_int);
   256	}
   257	
   258	/**
   259	 * goodix_reset - Reset device during power on
   260	 *
   261	 * @ts: goodix_ts_data pointer
   262	 */
   263	static int goodix_reset(struct goodix_ts_data *ts)
   264	{
   265		int error;
   266	
   267		/* begin select I2C slave addr */
   268		error = gpiod_direction_output(ts->gpiod_rst, 0);
   269		if (error)
   270			return error;
   271		msleep(20);				/* T2: > 10ms */
   272		/* HIGH: 0x28/0x29, LOW: 0xBA/0xBB */
   273		error = gpiod_direction_output(ts->gpiod_int, ts->client->addr == 0x14);
   274		if (error)
   275			return error;
   276		usleep_range(100, 2000);		/* T3: > 100us */
   277		error = gpiod_direction_output(ts->gpiod_rst, 1);
   278		if (error)
   279			return error;
   280		usleep_range(6000, 10000);		/* T4: > 5ms */
   281		/* end select I2C slave addr */
   282		error = gpiod_direction_input(ts->gpiod_rst);
   283		if (error)
   284			return error;
   285		return goodix_int_sync(ts);
   286	}
   287	
   288	/**
   289	 * goodix_get_gpio_config - Get GPIO config from ACPI/DT
   290	 *
   291	 * @ts: goodix_ts_data pointer
   292	 */
   293	static int goodix_get_gpio_config(struct goodix_ts_data *ts)
   294	{
   295		int error;
   296		struct device *dev;
   297		struct gpio_desc *gpiod;
   298	
   299		if (!ts->client)
   300			return -EINVAL;
   301		dev = &ts->client->dev;
   302	
   303		/* Get the interrupt GPIO pin number */
 > 304		gpiod = devm_gpiod_get(dev, GOODIX_GPIO_INT_NAME, GPIOD_IN);
   305		if (IS_ERR(gpiod)) {
   306			error = PTR_ERR(gpiod);
   307			if (error != -EPROBE_DEFER)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Thread

[PATCH v8 0/9] Goodix touchscreen enhancements Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 16:30 +0200
  [PATCH v8 8/9] Input: goodix - add runtime power management support Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 16:30 +0200
  [PATCH v8 9/9] Input: goodix - sort includes using inverse Xmas tree order Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 16:30 +0200
  [PATCH v8 4/9] Input: goodix - add power management support Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 16:30 +0200
  [PATCH v8 1/9] Input: goodix - use actual config length for each device type Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 16:30 +0200
  [PATCH v8 7/9] Input: goodix - add sysfs interface to dump config Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 16:30 +0200
  [PATCH v8 5/9] Input: goodix - use goodix_i2c_write_u8 instead of i2c_master_send Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 16:30 +0200
  [PATCH v8 3/9] Input: goodix - write configuration data to device Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 16:30 +0200
  Re: [PATCH v8 0/9] Goodix touchscreen enhancements Arnd Bergmann <arnd@arndb.de> - 2015-10-08 16:40 +0200
    RE: [PATCH v8 0/9] Goodix touchscreen enhancements "Tirdea, Irina" <irina.tirdea@intel.com> - 2015-10-09 13:10 +0200
      Re: [PATCH v8 0/9] Goodix touchscreen enhancements Arnd Bergmann <arnd@arndb.de> - 2015-10-09 14:00 +0200
  [PATCH v8 2/9] Input: goodix - reset device at init Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 16:40 +0200
    Re: [PATCH v8 2/9] Input: goodix - reset device at init Bastien Nocera <hadess@hadess.net> - 2015-10-09 16:30 +0200
    Re: [PATCH v8 2/9] Input: goodix - reset device at init kbuild test robot <lkp@intel.com> - 2015-10-11 01:40 +0200
  Re: [PATCH v8 0/9] Goodix touchscreen enhancements Bastien Nocera <hadess@hadess.net> - 2015-10-09 16:30 +0200
  Re: [PATCH v8 0/9] Goodix touchscreen enhancements Aleksei Mamlin <mamlinav@gmail.com> - 2015-10-09 18:10 +0200

csiph-web