Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1243248

RE: [PATCH v8 0/9] Goodix touchscreen enhancements

Show all headers | View raw

> -----Original Message-----
> From: linux-input-owner@vger.kernel.org [mailto:linux-input-owner@vger.kernel.org] On Behalf Of Arnd Bergmann
> Sent: 08 October, 2015 17:32
> To: Tirdea, Irina
> Cc: Dmitry Torokhov; Bastien Nocera; Aleksei Mamlin; linux-input@vger.kernel.org; Mark Rutland; Purdila, Octavian; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [PATCH v8 0/9] Goodix touchscreen enhancements
> 
> On Thursday 08 October 2015 17:23:42 Irina Tirdea wrote:
> > Add several enhancements to the Goodix touchscreen driver.
> >
> > The new functionality is only available for devices that
> > declare named gpio pins for interrupt and reset in their
> > ACPI/DT configuration.
> >
> > Thanks,
> > Irina
> >
> > Changes in v8:
> >  - only allow new functionality for devices that declare named
> > gpios (using _DSD properties in ACPI or named DT properties)
> >
> >
> 
> Looks much cleaner this way, thanks!
> 
> One remaining question: how would you handle the case where
> the hardware doesn't support configuring the int-gpios line
> as output but you still want to use the named gpios?
> 

The only reason to use named gpios is to enable the new functionality
introduced by this patch set (mainly reset and power management).
You cannot use only one gpio either (e.g. only reset gpio but not the
interrupt gpio), you need both for this functionality to work.

If the hardware does not support using the interrupt gpio pin as output,
it should not declare the named int-gpio pin in ACPI. It is true that
we might later run into platforms that declare the int-gpio pin even if it
does not actually work (just like we now have the indexed gpio pins).
I could have added an additional property for this as you first suggested,
but if we can modify the ACPI to add it, we could simply remove the
named interrupt pin instead (that does not work anyway).

> I assume you have that case covered, but I don't see it immediately.
> 
> 	Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v8 0/9] Goodix touchscreen enhancements Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 16:30 +0200
  [PATCH v8 8/9] Input: goodix - add runtime power management support Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 16:30 +0200
  [PATCH v8 9/9] Input: goodix - sort includes using inverse Xmas tree order Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 16:30 +0200
  [PATCH v8 4/9] Input: goodix - add power management support Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 16:30 +0200
  [PATCH v8 1/9] Input: goodix - use actual config length for each device type Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 16:30 +0200
  [PATCH v8 7/9] Input: goodix - add sysfs interface to dump config Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 16:30 +0200
  [PATCH v8 5/9] Input: goodix - use goodix_i2c_write_u8 instead of i2c_master_send Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 16:30 +0200
  [PATCH v8 3/9] Input: goodix - write configuration data to device Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 16:30 +0200
  Re: [PATCH v8 0/9] Goodix touchscreen enhancements Arnd Bergmann <arnd@arndb.de> - 2015-10-08 16:40 +0200
    RE: [PATCH v8 0/9] Goodix touchscreen enhancements "Tirdea, Irina" <irina.tirdea@intel.com> - 2015-10-09 13:10 +0200
      Re: [PATCH v8 0/9] Goodix touchscreen enhancements Arnd Bergmann <arnd@arndb.de> - 2015-10-09 14:00 +0200
  [PATCH v8 2/9] Input: goodix - reset device at init Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 16:40 +0200
    Re: [PATCH v8 2/9] Input: goodix - reset device at init Bastien Nocera <hadess@hadess.net> - 2015-10-09 16:30 +0200
    Re: [PATCH v8 2/9] Input: goodix - reset device at init kbuild test robot <lkp@intel.com> - 2015-10-11 01:40 +0200
  Re: [PATCH v8 0/9] Goodix touchscreen enhancements Bastien Nocera <hadess@hadess.net> - 2015-10-09 16:30 +0200
  Re: [PATCH v8 0/9] Goodix touchscreen enhancements Aleksei Mamlin <mamlinav@gmail.com> - 2015-10-09 18:10 +0200

csiph-web