Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1244014

Re: [PATCH 5/5] arm: add missing of_node_put

Show all headers | View raw

Arnd,

On Sat, 10 Oct 2015 23:02:15 +0200, Arnd Bergmann wrote:

> The same for_each_child_of_node() loop has three 'return' statements'
> aside from the 'break' statement here. I think you should change your
> semantic patch to cover both cases.

I think Julia's semantic patch covers both cases, but only the cases
where there is one break or return (though I have essentially zero
Coccinelle knowledge, this is all based on guessing looking at the
semantic patch in the cover letter).

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 5/5] arm: add missing of_node_put Julia Lawall <Julia.Lawall@lip6.fr> - 2015-10-10 14:50 +0200
  Re: [PATCH 5/5] arm: add missing of_node_put Arnd Bergmann <arnd@arndb.de> - 2015-10-10 23:10 +0200
    Re: [PATCH 5/5] arm: add missing of_node_put Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-10-10 23:10 +0200
      Re: [PATCH 5/5] arm: add missing of_node_put Julia Lawall <julia.lawall@lip6.fr> - 2015-10-10 23:20 +0200
    Re: [PATCH 5/5] arm: add missing of_node_put Julia Lawall <julia.lawall@lip6.fr> - 2015-10-10 23:20 +0200
      Re: [PATCH 5/5] arm: add missing of_node_put Arnd Bergmann <arnd@arndb.de> - 2015-10-10 23:20 +0200
        [PATCH 5/5 v2] arm: add missing of_node_put Julia Lawall <julia.lawall@lip6.fr> - 2015-10-10 23:50 +0200

csiph-web