Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1244012

Re: [PATCH 5/5] arm: add missing of_node_put

Show all headers | View raw

On Saturday 10 October 2015 14:30:54 Julia Lawall wrote:
> diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c
> index 11c54de..432ff34 100644
> --- a/arch/arm/kernel/devtree.c
> +++ b/arch/arm/kernel/devtree.c
> @@ -143,6 +143,7 @@ void __init arm_dt_init_cpu_maps(void)
>                                                "max cores %u, capping them\n",
>                                                cpuidx, nr_cpu_ids)) {
>                         cpuidx = nr_cpu_ids;
> +                       of_node_put(cpu);
>                         break;
>                 }
> 

The same for_each_child_of_node() loop has three 'return' statements'
aside from the 'break' statement here. I think you should change your
semantic patch to cover both cases.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 5/5] arm: add missing of_node_put Julia Lawall <Julia.Lawall@lip6.fr> - 2015-10-10 14:50 +0200
  Re: [PATCH 5/5] arm: add missing of_node_put Arnd Bergmann <arnd@arndb.de> - 2015-10-10 23:10 +0200
    Re: [PATCH 5/5] arm: add missing of_node_put Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-10-10 23:10 +0200
      Re: [PATCH 5/5] arm: add missing of_node_put Julia Lawall <julia.lawall@lip6.fr> - 2015-10-10 23:20 +0200
    Re: [PATCH 5/5] arm: add missing of_node_put Julia Lawall <julia.lawall@lip6.fr> - 2015-10-10 23:20 +0200
      Re: [PATCH 5/5] arm: add missing of_node_put Arnd Bergmann <arnd@arndb.de> - 2015-10-10 23:20 +0200
        [PATCH 5/5 v2] arm: add missing of_node_put Julia Lawall <julia.lawall@lip6.fr> - 2015-10-10 23:50 +0200

csiph-web