Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1243992

[PATCH 1/2] atm: iphase: return -ENOMEM instead of -1 in case of failed kmalloc()

Show all headers | View raw

Smatch complains about returning hard coded error codes, silence this
warning.

drivers/atm/iphase.c:115 ia_enque_rtn_q() warn: returning -1 instead of -ENOMEM is sloppy

Signed-off-by: Tillmann Heidsieck <theidsieck@leenox.de>
---
 drivers/atm/iphase.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
index 65e65903faa0..d5010d7a99c3 100644
--- a/drivers/atm/iphase.c
+++ b/drivers/atm/iphase.c
@@ -112,7 +112,8 @@ static void ia_enque_head_rtn_q (IARTN_Q *que, IARTN_Q * data)
 
 static int ia_enque_rtn_q (IARTN_Q *que, struct desc_tbl_t data) {
    IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_ATOMIC);
-   if (!entry) return -1;
+   if (!entry)
+      return -ENOMEM;
    entry->data = data;
    entry->next = NULL;
    if (que->next == NULL) 
-- 
2.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] atm: iphase: Fix misleading indention and return -ENOMEM on error Tillmann Heidsieck <theidsieck@leenox.de> - 2015-10-10 21:50 +0200
  [PATCH 1/2] atm: iphase: return -ENOMEM instead of -1 in case of failed kmalloc() Tillmann Heidsieck <theidsieck@leenox.de> - 2015-10-10 21:50 +0200
    Re: [PATCH 1/2] atm: iphase: return -ENOMEM instead of -1 in case  of failed kmalloc() David Miller <davem@davemloft.net> - 2015-10-13 04:50 +0200
  Re: [PATCH 0/2] atm: iphase: Fix misleading indention and return  -ENOMEM on error "Charles (Chas) Williams" <3chas3@gmail.com> - 2015-10-12 17:30 +0200

csiph-web