Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1243880

Re: [PATCH 06/10] iommu/amd: Add functions copy_command_buffer/copy_event_buffer

Show all headers | View raw

Hi Joerg,

On 09/29/15 at 06:04pm, Joerg Roedel wrote:
> On Thu, Sep 24, 2015 at 02:37:32PM +0800, Baoquan He wrote:
> > Copy command buffer and event buffer from the old to kdump kernel.
> > 
> > Still there are 2 problems:
> >   1) Not very sure if this is necessary. If do not copy the old command buffer, and
> > only set the newly allocated command buffer, is there anything wrong?
> 
> No, there is no need to copy command and event buffers. Just make sure
> they get re-initialized and flush all iommu caches after setting the new
> device table.

Thanks for your reviewing.

I did a lot of tests. Seems that it doesn't matter with copy or without
a copy. And it's also OK even completely ignore the command buffer and
event log handling here.

Thanks
Baoquan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 06/10] iommu/amd: Add functions  copy_command_buffer/copy_event_buffer Baoquan He <bhe@redhat.com> - 2015-10-10 14:30 +0200

csiph-web