Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1243881

Re: [PATCH 09/10] iommu/amd: Clear the iommu pre enabled setting

Show all headers | View raw

On 09/29/15 at 06:09pm, Joerg Roedel wrote:
> On Thu, Sep 24, 2015 at 02:37:35PM +0800, Baoquan He wrote:
> > @@ -2469,6 +2469,8 @@ static dma_addr_t __map_single(struct device *dev,
> >  	unsigned long align_mask = 0;
> >  	int i;
> >  
> > +	if (translation_pre_enabled())
> > +		clear_translation_pre_enabled();
> 
> There is probably a better place to do this somewhere in the
> initialization state machine of the AMD IOMMU driver.

Yeah, I put it in state_next().

static int __init state_next(void)
{
        int ret = 0;

        switch (init_state) {
        case IOMMU_START_STATE:
	......

	case IOMMU_DMA_OPS:
                if (translation_pre_enabled())
                        clear_translation_pre_enabled();
                init_state = IOMMU_INITIALIZED;
                break;
	......
}

> 
> 
> 	Joerg
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 09/10] iommu/amd: Clear the iommu pre enabled setting Baoquan He <bhe@redhat.com> - 2015-10-10 14:40 +0200

csiph-web