Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1242277

Re: [PATCH net-next 0/3] net: remove dsa.h from netdevice.h

Show all headers | View raw

From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Tue,  6 Oct 2015 17:54:24 -0400

> In order to push switchdev objects down to DSA drivers, I need to include
> switchdev.h in dsa.h. But compilation fails because of a circular dependency
> issue, since dsa.h is also included in linux/netdevice.h.
> 
> dsa.h is included for two purposes: to have the definition of struct
> dsa_switch_tree; and to have access to dsa_uses_tagged_protocol(), used by
> netdev_uses_dsa().
> 
> This patchset forward declares struct dsa_switch_tree; adds a new uses_hw_tag
> boolean to struct net_device, which is more explicit than the DSA helper, and
> finally get rid of the dsa.h include.
> 
> With this patchset, switchdev.h can safely be included in dsa.h.

The netdevice structure is already too big, and bloating it up even more
to satisfy some include ordering issue is rather unacceptable as far as I
am concerned.

Just forward declare the pointer type, you're not dereferencing it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 0/3] net: remove dsa.h from netdevice.h Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-07 00:20 +0200
  [PATCH net-next 1/3] net: dsa: add uses_hw_tag Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-07 00:20 +0200
  [PATCH net-next 2/3] net: dsa: include dsa.h in dsa_priv.h Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-07 00:20 +0200
  [PATCH net-next 3/3] net: remove dsa.h include from linux/netdevice.h Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-07 00:20 +0200
  Re: [PATCH net-next 0/3] net: remove dsa.h from netdevice.h Florian Fainelli <f.fainelli@gmail.com> - 2015-10-07 02:50 +0200
    Re: [PATCH net-next 0/3] net: remove dsa.h from netdevice.h Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-07 18:30 +0200
  Re: [PATCH net-next 0/3] net: remove dsa.h from netdevice.h Jiri Pirko <jiri@resnulli.us> - 2015-10-07 19:30 +0200
  Re: [PATCH net-next 0/3] net: remove dsa.h from netdevice.h David Miller <davem@davemloft.net> - 2015-10-08 13:50 +0200

csiph-web