Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1241108

Re: [PATCH net-next 0/3] net: remove dsa.h from netdevice.h

Show all headers | View raw

On 06/10/15 14:54, Vivien Didelot wrote:
> In order to push switchdev objects down to DSA drivers, I need to include
> switchdev.h in dsa.h. But compilation fails because of a circular dependency
> issue, since dsa.h is also included in linux/netdevice.h.

Just for the record, what does this circular dependency looks like? Last
I tried something in that front, I ended-up forward declaring the
'switchdev_obj' structure, but that was weeks ago before the whole
restructuring, so could be pointless now.

> 
> dsa.h is included for two purposes: to have the definition of struct
> dsa_switch_tree; and to have access to dsa_uses_tagged_protocol(), used by
> netdev_uses_dsa().
> 
> This patchset forward declares struct dsa_switch_tree; adds a new uses_hw_tag
> boolean to struct net_device, which is more explicit than the DSA helper, and
> finally get rid of the dsa.h include.
> 
> With this patchset, switchdev.h can safely be included in dsa.h.
> 
> Vivien Didelot (3):
>   net: dsa: add uses_hw_tag
>   net: dsa: include dsa.h in dsa_priv.h
>   net: remove dsa.h include from linux/netdevice.h
> 
>  include/linux/netdevice.h | 9 ++++++---
>  include/net/dsa.h         | 5 -----
>  net/dsa/dsa.c             | 1 +
>  net/dsa/dsa_priv.h        | 1 +
>  4 files changed, 8 insertions(+), 8 deletions(-)
> 


-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 0/3] net: remove dsa.h from netdevice.h Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-07 00:20 +0200
  [PATCH net-next 1/3] net: dsa: add uses_hw_tag Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-07 00:20 +0200
  [PATCH net-next 2/3] net: dsa: include dsa.h in dsa_priv.h Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-07 00:20 +0200
  [PATCH net-next 3/3] net: remove dsa.h include from linux/netdevice.h Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-07 00:20 +0200
  Re: [PATCH net-next 0/3] net: remove dsa.h from netdevice.h Florian Fainelli <f.fainelli@gmail.com> - 2015-10-07 02:50 +0200
    Re: [PATCH net-next 0/3] net: remove dsa.h from netdevice.h Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-07 18:30 +0200
  Re: [PATCH net-next 0/3] net: remove dsa.h from netdevice.h Jiri Pirko <jiri@resnulli.us> - 2015-10-07 19:30 +0200
  Re: [PATCH net-next 0/3] net: remove dsa.h from netdevice.h David Miller <davem@davemloft.net> - 2015-10-08 13:50 +0200

csiph-web