Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1243275

Re: [RFC PATCH] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [RFC PATCH] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message
Date Fri, 09 Oct 2015 13:40:02 +0200
Message-ID <qhEbM-R9-15@gated-at.bofh.it> (permalink)
References <qhkG5-6u9-7@gated-at.bofh.it> <qhliO-7tw-7@gated-at.bofh.it>
X-Original-To Michael Welling <mwelling@ieee.org>
MIME-Version 1.0
Content-Type multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RYJh/3oyKhIjGcML"
Content-Disposition inline
X-Cookie When in doubt, follow your heart.
User-Agent Mutt/1.5.23 (2014-03-12)
X-Sa-Exim-Connect-IP 37.228.227.108
X-Sa-Exim-Mail-From broonie@sirena.org.uk
X-Sa-Exim-Version 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-Sa-Exim-Scanned Yes (on mezzanine.sirena.org.uk)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 40
Organization linux.* mail to news gateway
X-Original-Cc Neil Armstrong <narmstrong@baylibre.com>, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Fionn Cleary <clearyf@tcd.ie>, Wolfram Sang <wsa@the-dreams.de>, Jarkko Nikula <jarkko.nikula@linux.intel.com>, Sebastian Reichel <sre@kernel.org>
X-Original-Date Fri, 9 Oct 2015 12:38:10 +0100
X-Original-Message-ID <20151009113810.GD1542@sirena.org.uk>
X-Original-References <5616816C.9020904@baylibre.com> <20151008152105.GA13157@deathstar>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1243275

Show key headers only | View raw


[Multipart message — attachments visible in raw view] - view raw

On Thu, Oct 08, 2015 at 10:21:05AM -0500, Michael Welling wrote:
> On Thu, Oct 08, 2015 at 04:45:00PM +0200, Neil Armstrong wrote:

> What is the point of doing this void cast below?
> Avoiding compiler warning perhaps?
> Perhaps you can __maybe_unused for the variable instead?

> > +	/* Ignore message */
> > +	(void)msg;

You shouldn't need it at all, but yes if there is a good reason to mark
something as unused the above annotation is better.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC PATCH] spi: omap2-mcspi: disable other channels CHCONF_FORCE in  prepare_message Neil Armstrong <narmstrong@baylibre.com> - 2015-10-08 16:50 +0200
  Re: [RFC PATCH] spi: omap2-mcspi: disable other channels  CHCONF_FORCE in prepare_message Michael Welling <mwelling@ieee.org> - 2015-10-08 17:30 +0200
    Re: [RFC PATCH] spi: omap2-mcspi: disable other channels  CHCONF_FORCE in prepare_message Mark Brown <broonie@kernel.org> - 2015-10-09 13:40 +0200
      Re: [RFC PATCH] spi: omap2-mcspi: disable other channels  CHCONF_FORCE in prepare_message Michael Welling <mwelling@ieee.org> - 2015-10-09 16:30 +0200
        Re: [RFC PATCH] spi: omap2-mcspi: disable other channels  CHCONF_FORCE in prepare_message Mark Brown <broonie@kernel.org> - 2015-10-14 13:00 +0200

csiph-web