Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1243275

Re: [RFC PATCH] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [RFC PATCH] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message
Date 2015-10-09 13:40 +0200
Message-ID <qhEbM-R9-15@gated-at.bofh.it> (permalink)
References <qhkG5-6u9-7@gated-at.bofh.it> <qhliO-7tw-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Thu, Oct 08, 2015 at 10:21:05AM -0500, Michael Welling wrote:
> On Thu, Oct 08, 2015 at 04:45:00PM +0200, Neil Armstrong wrote:

> What is the point of doing this void cast below?
> Avoiding compiler warning perhaps?
> Perhaps you can __maybe_unused for the variable instead?

> > +	/* Ignore message */
> > +	(void)msg;

You shouldn't need it at all, but yes if there is a good reason to mark
something as unused the above annotation is better.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC PATCH] spi: omap2-mcspi: disable other channels CHCONF_FORCE in  prepare_message Neil Armstrong <narmstrong@baylibre.com> - 2015-10-08 16:50 +0200
  Re: [RFC PATCH] spi: omap2-mcspi: disable other channels  CHCONF_FORCE in prepare_message Michael Welling <mwelling@ieee.org> - 2015-10-08 17:30 +0200
    Re: [RFC PATCH] spi: omap2-mcspi: disable other channels  CHCONF_FORCE in prepare_message Mark Brown <broonie@kernel.org> - 2015-10-09 13:40 +0200
      Re: [RFC PATCH] spi: omap2-mcspi: disable other channels  CHCONF_FORCE in prepare_message Michael Welling <mwelling@ieee.org> - 2015-10-09 16:30 +0200
        Re: [RFC PATCH] spi: omap2-mcspi: disable other channels  CHCONF_FORCE in prepare_message Mark Brown <broonie@kernel.org> - 2015-10-14 13:00 +0200

csiph-web