Re: [PATCH] thermal: exynos: fix register read in TMU

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] thermal: exynos: fix register read in TMU
Date	Fri, 09 Oct 2015 13:40:02 +0200
Message-ID	<qhEbM-R9-13@gated-at.bofh.it> (permalink)
References	<qeKx3-2WG-1@gated-at.bofh.it> <qeLW9-5iU-9@gated-at.bofh.it> <qeMSe-6WP-21@gated-at.bofh.it> <qeVLP-2W2-3@gated-at.bofh.it> <qhkmL-67a-39@gated-at.bofh.it>
X-Original-To	Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Lukasz Majewski <l.majewski@samsung.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=iiWFtxNj4/wcK3aeRk5FcK73eOAa7C/5/CIudcGrPOE=; b=s7is2al0I1rCVojBclAzk0x90GrSg4EEyFxL2ZA5MIdZV9fQebbaT+3z6lb9HZeWHu k6iSMYhPzT6rXYcAnjFqfo139dllO0Ql244P1SXetpm+pfcMKWley/r4AOdHTy1nhMrV wu4JeUaX7T3GEgugvpbBCEzJ+8acSMlheMG1ll4DWyP6Sx3h0Y4uR6j65FEehVNYCiel ZVpzJg8EKcQUo7asNaxJ3UcTBdtSAb3l8L8MGRqsvorjhz6AcL+UssMwo40F30j2aK7S dXqdJoP3ofMVuCUMtDJ/qjWD02h/QTAhAb05UHtaYapCfREhLbXb/EvybGPBgDTyelWd 3kxA==
MIME-Version	1.0
X-Received	by 10.140.235.16 with SMTP id g16mr15202313qhc.33.1444390550103; Fri, 09 Oct 2015 04:35:50 -0700 (PDT)
X-Google-Sender-Auth	u6wjsK0FVy1aRkVCV1NUHzb-JaU
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	49
Organization	linux.* mail to news gateway
X-Original-Cc	Krzysztof Kozlowski <k.kozlowski@samsung.com>, Zhang Rui <rui.zhang@intel.com>, Eduardo Valentin <edubezval@gmail.com>, Kukjin Kim <kgene@kernel.org>, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
X-Original-Date	Fri, 9 Oct 2015 20:35:50 +0900
X-Original-Message-ID	<CAJKOXPfbrdm75n_v+dRnq8dqAFAGvHj28QQ4ZY8WZms1D6eLZQ@mail.gmail.com>
X-Original-References	<1443699599-9693-1-git-send-email-sudipm.mukherjee@gmail.com> <CAJKOXPfyC8etcPe373q6Pc1qWb2zVnHE96V+Rh5mPmpzAxFjiA@mail.gmail.com> <20151001141243.GA5061@sudip-pc> <CAJKOXPdVs9i9sVP84wa2wU0qVH1-o4unvaDC+O7c1za6bJUSLw@mail.gmail.com> <20151008142129.GC10587@sudip-pc>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1243273

Show key headers only | View raw

2015-10-08 23:21 GMT+09:00 Sudip Mukherjee <sudipm.mukherjee@gmail.com>:
> On Fri, Oct 02, 2015 at 08:43:52AM +0900, Krzysztof Kozlowski wrote:
>> 2015-10-01 23:12 GMT+09:00 Sudip Mukherjee <sudipm.mukherjee@gmail.com>:
>> > On Thu, Oct 01, 2015 at 10:18:57PM +0900, Krzysztof Kozlowski wrote:
>> >> 2015-10-01 20:39 GMT+09:00 Sudip Mukherjee <sudipm.mukherjee@gmail.com>:
>> >> > The value of emul_con was getting overwritten if the selected soc is
>> >> > SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong
>> >> > register in the case of SOC_ARCH_EXYNOS5260.
>> >>
>> >> How the value is overwritten if the soc is Exynos5260? I can't see it
>> >> (although the "else if" is still more obvious than "if" but how does
>> >> the description match the code?).
>> > The code here is:
>> > if (data->soc == SOC_ARCH_EXYNOS5260)
>> >         emul_con = EXYNOS5260_EMUL_CON;
>> > if (data->soc == SOC_ARCH_EXYNOS5433)
>> >         emul_con = EXYNOS5433_TMU_EMUL_CON;
>> > else if (data->soc == SOC_ARCH_EXYNOS7)
>> >         emul_con = EXYNOS7_TMU_REG_EMUL_CON;
>> > else
>> >         emul_con = EXYNOS_EMUL_CON;
>> >
>> > So if data->soc is SOC_ARCH_EXYNOS5260 , then emul_con becomes
>> > EXYNOS5260_EMUL_CON. But again for the else part it will become
>> > EXYNOS_EMUL_CON.
>>
>> Indeed!
>>
>> Fixes: 488c7455d74c ("thermal: exynos: Add the support for Exynos5433 TMU")
>>
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Hi Krzysztof,
> Who will pick this one up? I still do not see it in linux-next.

Hi!

I guess it is a patch for Lukasz.

Lukasz,
Do you plan to pick it up or maybe this should go through samsung-soc tree?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] thermal: exynos: fix register read in TMU Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-08 16:30 +0200
  Re: [PATCH] thermal: exynos: fix register read in TMU Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-09 13:40 +0200
    Re: [PATCH] thermal: exynos: fix register read in TMU Lukasz Majewski <l.majewski@samsung.com> - 2015-10-09 14:10 +0200
      Re: [PATCH] thermal: exynos: fix register read in TMU Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-10 06:40 +0200

csiph-web