Re: [PATCH] thermal: exynos: fix register read in TMU

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] thermal: exynos: fix register read in TMU
Date	2015-10-08 16:30 +0200
Message-ID	<qhkmL-67a-39@gated-at.bofh.it> (permalink)
References	<qeKx3-2WG-1@gated-at.bofh.it> <qeLW9-5iU-9@gated-at.bofh.it> <qeMSe-6WP-21@gated-at.bofh.it> <qeVLP-2W2-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 02, 2015 at 08:43:52AM +0900, Krzysztof Kozlowski wrote:
> 2015-10-01 23:12 GMT+09:00 Sudip Mukherjee <sudipm.mukherjee@gmail.com>:
> > On Thu, Oct 01, 2015 at 10:18:57PM +0900, Krzysztof Kozlowski wrote:
> >> 2015-10-01 20:39 GMT+09:00 Sudip Mukherjee <sudipm.mukherjee@gmail.com>:
> >> > The value of emul_con was getting overwritten if the selected soc is
> >> > SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong
> >> > register in the case of SOC_ARCH_EXYNOS5260.
> >>
> >> How the value is overwritten if the soc is Exynos5260? I can't see it
> >> (although the "else if" is still more obvious than "if" but how does
> >> the description match the code?).
> > The code here is:
> > if (data->soc == SOC_ARCH_EXYNOS5260)
> >         emul_con = EXYNOS5260_EMUL_CON;
> > if (data->soc == SOC_ARCH_EXYNOS5433)
> >         emul_con = EXYNOS5433_TMU_EMUL_CON;
> > else if (data->soc == SOC_ARCH_EXYNOS7)
> >         emul_con = EXYNOS7_TMU_REG_EMUL_CON;
> > else
> >         emul_con = EXYNOS_EMUL_CON;
> >
> > So if data->soc is SOC_ARCH_EXYNOS5260 , then emul_con becomes
> > EXYNOS5260_EMUL_CON. But again for the else part it will become
> > EXYNOS_EMUL_CON.
> 
> Indeed!
> 
> Fixes: 488c7455d74c ("thermal: exynos: Add the support for Exynos5433 TMU")
> 
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Hi Krzysztof,
Who will pick this one up? I still do not see it in linux-next.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] thermal: exynos: fix register read in TMU Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-08 16:30 +0200
  Re: [PATCH] thermal: exynos: fix register read in TMU Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-09 13:40 +0200
    Re: [PATCH] thermal: exynos: fix register read in TMU Lukasz Majewski <l.majewski@samsung.com> - 2015-10-09 14:10 +0200
      Re: [PATCH] thermal: exynos: fix register read in TMU Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-10 06:40 +0200

csiph-web