Re: [PATCH v3] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL PCIe Host Controller

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!news.albasani.net!tahina.priv.at!bofh.it!news.nic.it!robomod
From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL PCIe Host Controller
Date	Fri, 09 Oct 2015 10:20:02 +0200
Message-ID	<qhB4e-4TO-7@gated-at.bofh.it> (permalink)
References	<qgD86-2O1-27@gated-at.bofh.it> <qhB4e-4TO-9@gated-at.bofh.it> <qhB4e-4TO-11@gated-at.bofh.it>
X-Original-To	Marc Zyngier <marc.zyngier@arm.com>
User-Agent	KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="us-ascii"
X-Provags-ID	V03:K0:tWt0HjKUGj8Pp9+UQvy0625m2yLnaj61qcUQJHVrJHO+SSXWog7 GJ4/VbJxmD2CXAKHuIZkqxh/P2/jieZneIiG9+ePNsaeMgOu7KBBzaudqnsjQIIHhfXARxO C0Hxz/1+Uc3lg3jmWrJb3OgrgTlTivslMSGrfu4rSqFEobRgGqD9AETy/KX69sMNj4/p6B5 j2EUZfpHAmjyezvrgxgPw==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:Xt8OxzuIe9c=:cKT8FmUj09a/baVFcWZTtd XWb+P9n1refsThCa9QtaKCvM8KkHadGK1A7/tmr9T0S/VZ6+8Y6EItltBc5O1/Tfz34e/357F x7R0Uh/U7LeOCZDX8S0z3s5Ejsp/XtVYWLkwGvpIEG+2ta642zUikLxlSRQkiNY6wJQIC4+0z hVub+imaZQcF4S4zJBhn0T9Lsi9mxpa75zICLUfLZC9KlD8xPEmDFpdYnog+3M9kzz94J9FtB IfjfseZXuC0C1nwj2a2VfdMiU6Siqll0GNXMADHYuXzr2OGjMjJ3KVDOD+RSUxUDw11WdmaaX 7kcpIFDVUfME3nZHfZ8m928HUXmguV/EfinY0vDSgntHMMUl9qK9Zq7nvh4G6bkyvk//qoq2A 7G70TEJyKgoRUx+JYQ/EE2kMVb0P5iufiKA8GlB2u/G4DnQsSKZJUDl3wxH1rFMfM6HU4WHqg tSfcnnYAW8uRMmKRCjYrqIUgYe5LyMZN2VmL8zau9AOkk3R2DSb9iufkrVOoAD/peelknAdjt VwhWO/QrUbb1YztbKvUekDK4I2vmkvgT9sFfEgrWVp+qMDmA67A5EzrDfQR683R8mlMy0flwL tzKuEK3DVxgrrnIitwlrRzIasaZi+x6iwnDnCTdgUKAIaFuLChA5RekMpilBrvhka52aKxAZ7 +JlRuJJiDTSHGGk2RDL400sbntDucmuA9FZXOmRzntN+ZAIBYP+RBxcBnloqlSMQNCdMadm+q myFpX6iW0qDVnySg
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	26
Organization	linux.* mail to news gateway
X-Original-Cc	Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "pawel.moll@arm.com" <pawel.moll@arm.com>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>, "galak@codeaurora.org" <galak@codeaurora.org>, Michal Simek <michals@xilinx.com>, Soren Brinkmann <sorenb@xilinx.com>, "bhelgaas@google.com" <bhelgaas@google.com>, "tinamdar@apm.com" <tinamdar@apm.com>, "treding@nvidia.com" <treding@nvidia.com>, "rjui@broadcom.com" <rjui@broadcom.com>, "Minghuan.Lian@freescale.com" <Minghuan.Lian@freescale.com>, "m-karicheri2@ti.com" <m-karicheri2@ti.com>, "hauke@hauke-m.de" <hauke@hauke-m.de>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Ravikiran Gummaluri <rgummal@xilinx.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>
X-Original-Date	Fri, 09 Oct 2015 10:18:21 +0200
X-Original-Message-ID	<5676910.8cxuyuvhpA@wuerfel>
X-Original-References	<1444146289-28940-1-git-send-email-bharatku@xilinx.com> <8520D5D51A55D047800579B09414719801690CD0@XAP-PVEXMBX01.xlnx.xilinx.com> <56177669.2000302@arm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1243108

Show key headers only | View raw

On Friday 09 October 2015 09:10:17 Marc Zyngier wrote:
> > Please let me know whether we require a separate msi file as
> > suggested in your previous comments to separate MSI controller and
> > PCIE controller in two files, if we don't have separate node. If we
> > do not need a separate node do we need to embed MSI controller child
> > node  in PCIe controller node itself, and what properties does this
> > child node will require other than 'interrupts'.
> 
> If you want to keep them in the same file, please at least have two
> separate patches. These are two different functions, and they should be
> reviewed separately.
> 
> It will help everyone to understand your code, and speed up the
> reviewing process.

Agreed. Also, the part we really want is to have the PCI controller
code decoupled enough from the MSI code that it will not require
further changes once Xilinx comes out with a chip that has a modern
GIC in it and the same PCIe host.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v3] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL  PCIe Host Controller Marc Zyngier <marc.zyngier@arm.com> - 2015-10-06 18:20 +0200
  Re: [PATCH v3] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL  PCIe Host Controller Marc Zyngier <marc.zyngier@arm.com> - 2015-10-06 18:50 +0200
    Re: [PATCH v3] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL  PCIe Host Controller Marc Zyngier <marc.zyngier@arm.com> - 2015-10-09 10:20 +0200
      Re: [PATCH v3] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL PCIe Host Controller Arnd Bergmann <arnd@arndb.de> - 2015-10-09 10:20 +0200
      Re: [PATCH v3] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL  PCIe Host Controller Marc Zyngier <marc.zyngier@arm.com> - 2015-10-09 11:10 +0200
  Re: [PATCH v3] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL  PCIe Host Controller Marc Zyngier <marc.zyngier@arm.com> - 2015-10-09 16:20 +0200

csiph-web