Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1241939

Re: [PATCH 2/2] ASoC: Codec: wm8962: declare ALC Coefficients as 4 separate registers

Show all headers | View raw

Hi


On 10/06/2015 08:01 PM, Mark Brown wrote:
> On Tue, Oct 06, 2015 at 04:06:55PM +0900, Jiada Wang wrote:
>
>> As ALC2 register is volatile, declare it as one of ALC Coefficients
>> register together with other non-volatile registers will cause issue,
>> in case wm8962 has enter suspend mode, and cache_only flag is set,
>> any attempt to read from ALC2 will fail.
>
>> Instead of declaring one ALC Coefficients register which contains
>> ALC1 ~ ALC3 and Noise Gate, this patch declares 4 separate registers,
>> so that regmap can handle these registers differently based on their
>> classification.
>
> I don't understand this commit log.  Why does regmap care how these
> registers are presented to userspace, and how does splitting the
> controls up address the problem with one of the registers being volatile?
> Surely that register still has the same problem?
>
.get callback function will call regmap_raw_read() to read register
value from these registers, when these 4 regsters are declared as one
"ALC coefficient" register, condition check of regmap_volatile_range()
will return false, thus regmap will go word by word for the cache from
each register of "ALC Coefficient", the failure scenario is, when
wm8962 is in suspend mode (cache_only flag is set), as ALC2 doesn't
have cached value, then any attempt to read from it fails,

By splitting these registers, regmap can handle ALC2 as a single
volatile register, and always read from HW

Thanks,
Jiada

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] *** wm8962 regmap related fix *** Jiada Wang <jiada_wang@mentor.com> - 2015-10-06 09:10 +0200
  [PATCH 2/2] ASoC: Codec: wm8962: declare ALC Coefficients as 4 separate registers Jiada Wang <jiada_wang@mentor.com> - 2015-10-06 09:10 +0200
    Re: [PATCH 2/2] ASoC: Codec: wm8962: declare ALC Coefficients as 4  separate registers Mark Brown <broonie@kernel.org> - 2015-10-06 13:10 +0200
      Re: [PATCH 2/2] ASoC: Codec: wm8962: declare ALC Coefficients as  4 separate registers Jiada Wang <jiada_wang@mentor.com> - 2015-10-08 05:20 +0200
  [PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software reset in pm_resume Jiada Wang <jiada_wang@mentor.com> - 2015-10-06 09:10 +0200
    Re: [PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software  reset in pm_resume Mark Brown <broonie@kernel.org> - 2015-10-06 13:10 +0200
      Re: [PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software  reset in pm_resume Jiada Wang <jiada_wang@mentor.com> - 2015-10-08 03:40 +0200

csiph-web