Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1240368

Re: [PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software reset in pm_resume

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software reset in pm_resume
Date 2015-10-06 13:10 +0200
Message-ID <qgyi5-4m5-13@gated-at.bofh.it> (permalink)
References <qguxP-7kY-3@gated-at.bofh.it> <qguxP-7kY-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Tue, Oct 06, 2015 at 04:06:54PM +0900, Jiada Wang wrote:

> +	/* All registers have been reset to default value without calling
> +	 * to regmap interface, even if reset fails, some registers
> +	 * maybe in intermediate status, so we need to mark regmap
> +	 * cache_dirty flag.
> +	 */
> +	regcache_mark_dirty(wm8962->regmap);

This is a standard thing that applies to almost all devices, there
should be no need for such an extensive comment (which would normally
flag up that there's something weird and surprising going on).

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/2] *** wm8962 regmap related fix *** Jiada Wang <jiada_wang@mentor.com> - 2015-10-06 09:10 +0200
  [PATCH 2/2] ASoC: Codec: wm8962: declare ALC Coefficients as 4 separate registers Jiada Wang <jiada_wang@mentor.com> - 2015-10-06 09:10 +0200
    Re: [PATCH 2/2] ASoC: Codec: wm8962: declare ALC Coefficients as 4  separate registers Mark Brown <broonie@kernel.org> - 2015-10-06 13:10 +0200
      Re: [PATCH 2/2] ASoC: Codec: wm8962: declare ALC Coefficients as  4 separate registers Jiada Wang <jiada_wang@mentor.com> - 2015-10-08 05:20 +0200
  [PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software reset in pm_resume Jiada Wang <jiada_wang@mentor.com> - 2015-10-06 09:10 +0200
    Re: [PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software  reset in pm_resume Mark Brown <broonie@kernel.org> - 2015-10-06 13:10 +0200
      Re: [PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software  reset in pm_resume Jiada Wang <jiada_wang@mentor.com> - 2015-10-08 03:40 +0200

csiph-web