Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1241741

Re: [PATCH] gpio: make GPIO_OMAP bool instead of tristate

Show all headers | View raw

On 10/07/2015 02:27 AM, Sudip Mukherjee wrote:
> On Tue, Oct 06, 2015 at 03:45:07PM -0500, Grygorii Strashko wrote:
>> On 10/06/2015 07:01 AM, Sudip Mukherjee wrote:
>>> While building arm allmodconfig the build fails with the error:
>>> ERROR: "handle_bad_irq" [drivers/gpio/gpio-omap.ko] undefined!
>>>
>>> The build breaks as handle_bad_irq is not exported for module use.
>>
>> Not sure if this is right thing to do. We really want it to be a module if needed.
>>
>> The handle_bad_irq() was used in this driver to catch the case when Omap
>> GPIO IRQ is enabled before calling .irq_set_type()
>>
>> I think there are few option:
>> - export handle_bad_irq()
>> - pass NULL in gpiochip_irqchip_add() instead of handle_bad_irq()
>> - use handle_simple_irq()
>> - revert this change
>>
>> Thought second one should work.
>
> I think that should be ok. If you want me to test the patch in my setup
> to verify that it fixes the build failure please let me know.
>
> But going through the old thread it looked like plan was on to
> export handle_bad_irq() atleast thats what looks like from Linus's
> (Linus Walleij) reply in https://lkml.org/lkml/2014/2/25/119

There is patch from Arnd which implements option one.
https://lkml.org/lkml/2015/10/6/836

-- 
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] gpio: make GPIO_OMAP bool instead of tristate Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-06 14:10 +0200
  Re: [PATCH] gpio: make GPIO_OMAP bool instead of tristate Grygorii Strashko <grygorii.strashko@ti.com> - 2015-10-06 22:50 +0200
    Re: [PATCH] gpio: make GPIO_OMAP bool instead of tristate Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-07 09:30 +0200
      Re: [PATCH] gpio: make GPIO_OMAP bool instead of tristate Grygorii Strashko <grygorii.strashko@ti.com> - 2015-10-07 21:20 +0200
  Re: [PATCH] gpio: make GPIO_OMAP bool instead of tristate Linus Walleij <linus.walleij@linaro.org> - 2015-10-16 17:10 +0200

csiph-web