Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1240982

Re: [PATCH] gpio: make GPIO_OMAP bool instead of tristate

Show all headers | View raw

On 10/06/2015 07:01 AM, Sudip Mukherjee wrote:
> While building arm allmodconfig the build fails with the error:
> ERROR: "handle_bad_irq" [drivers/gpio/gpio-omap.ko] undefined!
> 
> The build breaks as handle_bad_irq is not exported for module use.

Not sure if this is right thing to do. We really want it to be a module if needed.

The handle_bad_irq() was used in this driver to catch the case when Omap
GPIO IRQ is enabled before calling .irq_set_type()   

I think there are few option:
- export handle_bad_irq()
- pass NULL in gpiochip_irqchip_add() instead of handle_bad_irq()
- use handle_simple_irq()
- revert this change

Thought second one should work. 
> 
> Fixes: 450fa54cfd66 ("gpio: omap: convert to use generic irq handler")
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Austin Schuh <austin@peloton-tech.com>
> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
> Cc: Santosh Shilimkar <ssantosh@kernel.org>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> 
> Same problem for pinctrl was fixed by
> 5ba341604a054294aeb812603349bba024d716ee
> 
> And for your reference:
> https://lkml.org/lkml/2014/2/25/278
> 
>   drivers/gpio/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 63000b1..d910fd1 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -330,7 +330,7 @@ config GPIO_OCTEON
>   	  family of SOCs.
>   
>   config GPIO_OMAP
> -	tristate "TI OMAP GPIO support" if ARCH_OMAP2PLUS || COMPILE_TEST
> +	bool "TI OMAP GPIO support" if ARCH_OMAP2PLUS || COMPILE_TEST
>   	default y if ARCH_OMAP
>   	depends on ARM
>   	select GENERIC_IRQ_CHIP
> 


-- 
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] gpio: make GPIO_OMAP bool instead of tristate Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-06 14:10 +0200
  Re: [PATCH] gpio: make GPIO_OMAP bool instead of tristate Grygorii Strashko <grygorii.strashko@ti.com> - 2015-10-06 22:50 +0200
    Re: [PATCH] gpio: make GPIO_OMAP bool instead of tristate Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-07 09:30 +0200
      Re: [PATCH] gpio: make GPIO_OMAP bool instead of tristate Grygorii Strashko <grygorii.strashko@ti.com> - 2015-10-07 21:20 +0200
  Re: [PATCH] gpio: make GPIO_OMAP bool instead of tristate Linus Walleij <linus.walleij@linaro.org> - 2015-10-16 17:10 +0200

csiph-web