Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239532

Re: [PATCH v5 1/2] PM / sleep: Go direct_complete if driver has no callbacks

Show all headers | View raw

On Monday, October 05, 2015 11:07:27 AM Pavel Machek wrote:
> On Mon 2015-10-05 10:25:45, Tomeu Vizoso wrote:
> > On 4 October 2015 at 17:16, Pavel Machek <pavel@ucw.cz> wrote:
> > > On Tue 2015-09-29 14:29:19, Tomeu Vizoso wrote:
> > >> If a suitable prepare callback cannot be found for a given device and
> > >> its driver has no PM callbacks at all, assume that it can go direct to
> > >> complete when the system goes to sleep.
> > >>
> > >> The reason for this is that there's lots of devices in a system that do
> > >> no PM at all and there's no reason for them to prevent their ancestors
> > >> to do direct_complete if they can support it.
> > >
> > > Dunno. This sounds like asking for trouble. Even if most devices can handle
> > > this, is not this bound to introduce some bugs?
> > 
> > Hi Pavel,
> > 
> > in which situations do you think that this could be problematic?
> 
> Well.. driver with no PM callbacks probably works "by accident",

How exactly?

Do you have at least one example of that?

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 1/2] PM / sleep: Go direct_complete if driver has no callbacks Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-29 14:40 +0200
  Re: [PATCH v5 1/2] PM / sleep: Go direct_complete if driver has no  callbacks kbuild test robot <lkp@intel.com> - 2015-09-29 15:40 +0200
  Re: [PATCH v5 1/2] PM / sleep: Go direct_complete if driver has no  callbacks kbuild test robot <lkp@intel.com> - 2015-09-29 15:40 +0200
  Re: [PATCH v5 1/2] PM / sleep: Go direct_complete if driver has no  callbacks kbuild test robot <lkp@intel.com> - 2015-09-29 15:50 +0200
  Re: [PATCH v5 1/2] PM / sleep: Go direct_complete if driver has no  callbacks Alan Stern <stern@rowland.harvard.edu> - 2015-09-29 16:40 +0200
  Re: [PATCH v5 1/2] PM / sleep: Go direct_complete if driver has no  callbacks Pavel Machek <pavel@ucw.cz> - 2015-10-04 17:20 +0200
    Re: [PATCH v5 1/2] PM / sleep: Go direct_complete if driver has no callbacks Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-10-05 10:30 +0200
      Re: [PATCH v5 1/2] PM / sleep: Go direct_complete if driver has no  callbacks Pavel Machek <pavel@ucw.cz> - 2015-10-05 11:10 +0200
        Re: [PATCH v5 1/2] PM / sleep: Go direct_complete if driver has no callbacks "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-05 15:10 +0200

csiph-web