Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239531

Re: [PATCH] iwlwifi: Deinline iwl_write8/write32/read32()

Show all headers | View raw

Hi Denys,

On Thu, 2015-09-24 at 16:58 +0200, Denys Vlasenko wrote:
> With this .config: http://busybox.net/~vda/kernel_config_ALLYES_Os,
> after deinlining these functions have sizes and callsite counts
> as follows:
> 
> iwl_write8: 315 bytes, 3 calls
> iwl_write32: 296 bytes, 90 calls
> iwl_read32: 278 bytes, 51 calls
> 
> Total size reduction is about 40 kbytes.
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> CC: Johannes Berg <johannes.berg@intel.com>
> CC: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> CC: Intel Linux Wireless <ilw@linux.intel.com>
> CC: Gregory Greenman <gregory.greenman@intel.com>
> CC: John Linville <linville@tuxdriver.com>
> CC: linux-wireless@vger.kernel.org
> CC: linux-kernel@vger.kernel.org

Emmanuel already wrote and applied a patch like this.  Check here:
http://mid.gmane.org/1442869141-31637-4-git-send-email-luca@coelho.fi

Thanks for your patch anyway and for reporting this. :)

--
Cheers,
Luca.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] iwlwifi: Deinline iwl_write8/write32/read32() Denys Vlasenko <dvlasenk@redhat.com> - 2015-09-24 17:00 +0200
  Re: [PATCH] iwlwifi: Deinline iwl_write8/write32/read32() Luca Coelho <luca@coelho.fi> - 2015-10-05 15:10 +0200

csiph-web