Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1241495
| From | Maurizio Lombardi <mlombard@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] bnx2fc: reduce stack usage in __bnx2fc_enable |
| Date | 2015-10-07 15:30 +0200 |
| Message-ID | <qgWXa-65g-53@gated-at.bofh.it> (permalink) |
| References | <qgWNs-5TU-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi, On 10/07/2015 03:11 PM, Arnd Bergmann wrote: > - memset(&npiv_tbl, 0, sizeof(npiv_tbl)); > - if (hba->cnic->get_fc_npiv_tbl(hba->cnic, &npiv_tbl)) > + npiv_tbl = kzalloc(sizeof(struct cnic_fc_npiv_tbl), GFP_KERNEL); > + if (!npiv_tbl) > goto done; > If kzalloc() fails perhaps the function should return -ENOMEM, not zero. Regards, Maurizio Lombardi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] bnx2fc: reduce stack usage in __bnx2fc_enable Arnd Bergmann <arnd@arndb.de> - 2015-10-07 15:20 +0200
Re: [PATCH] bnx2fc: reduce stack usage in __bnx2fc_enable Maurizio Lombardi <mlombard@redhat.com> - 2015-10-07 15:30 +0200
Re: [PATCH] bnx2fc: reduce stack usage in __bnx2fc_enable Chad Dupuis <chad.dupuis@qlogic.com> - 2015-10-07 21:00 +0200
csiph-web