Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1241494

Re: [PATCH v2 2/3] nvmem: core: set the size for the nvmem binary file.

Show all headers | View raw

On 07/10/15 13:56, Greg KH wrote:
> On Wed, Oct 07, 2015 at 12:00:55PM +0100, Srinivas Kandagatla wrote:
>> This patch sets the actual size of binary file to the nvmem size.
>> Previously this was not possible as the core was using the static global
>> data structures for attributes.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>>   drivers/nvmem/core.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
>> index 0a70e31..737fa75 100644
>> --- a/drivers/nvmem/core.c
>> +++ b/drivers/nvmem/core.c
>> @@ -315,6 +315,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
>>   	if (!nvmem->read_only)
>>   		nvmem->bin.attr.mode |= S_IWUSR;
>>
>> +	nvmem->bin.size = nvmem->size;
>
> Why does the size matter?  What userspace tool needs to know this?
Yes, you are correct, sized should not matter as read would return EOF 
anyway.
I think I overdone this :-)

--srini
>
> thanks,
>
> greg k-h
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/3] nvmem: core: set the size for the nvmem binary file. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-10-07 13:10 +0200
  Re: [PATCH v2 2/3] nvmem: core: set the size for the nvmem binary  file. Greg KH <gregkh@linuxfoundation.org> - 2015-10-07 15:00 +0200
    Re: [PATCH v2 2/3] nvmem: core: set the size for the nvmem binary  file. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-10-07 15:30 +0200

csiph-web