Re: [PATCH] ARM:mm: fix kmap_atomic_to_page

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Jongsung Kim <neidhard.kim@lge.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM:mm: fix kmap_atomic_to_page
Date	Wed, 07 Oct 2015 06:20:01 +0200
Message-ID	<qgOmR-2dJ-5@gated-at.bofh.it> (permalink)
References	<qgyBr-4Iz-17@gated-at.bofh.it> <qgG5Y-73b-29@gated-at.bofh.it> <qgLS1-6V0-7@gated-at.bofh.it>
X-Original-To	Nicolas Pitre <nicolas.pitre@linaro.org>, Russell King - ARM Linux <linux@arm.linux.org.uk>
X-Greylist	delayed 900 seconds by postgrey-1.27 at vger.kernel.org; Wed, 07 Oct 2015 00:11:06 EDT
X-Original-Senderip	156.147.1.127
X-Original-Mailfrom	neidhard.kim@lge.com
X-Original-Senderip	10.178.37.74
X-Original-Mailfrom	neidhard.kim@lge.com
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	28
Organization	linux.* mail to news gateway
X-Original-Cc	Chanho Min <chanho.min@lge.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Gunho Lee <gunho.lee@lge.com>
X-Original-Date	Wed, 7 Oct 2015 12:55:08 +0900
X-Original-Message-ID	<5614979C.30100@lge.com>
X-Original-References	<1444129773-12632-1-git-send-email-chanho.min@lge.com> <20151006192836.GX21513@n2100.arm.linux.org.uk> <alpine.LFD.2.20.1510062136190.1531@knanqh.ubzr>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1241147

Show key headers only | View raw

Recently, we made a driver utilizing kmap_atomic_to_page. Of course, it's not mainlined. People may be using it outside mainline just like us.

vmalloc has vmalloc_to_page, pkmap has kmap_to page, and fixmap has kmap_atomic_to_page. Then.. how about letting virt_to_page do them all?


On 10/07/2015 10:37 AM, Nicolas Pitre wrote:
> On Tue, 6 Oct 2015, Russell King - ARM Linux wrote:
>
>> On Tue, Oct 06, 2015 at 08:09:33PM +0900, Chanho Min wrote:
>>> Since kmap_atomic returns the pkmap address without a new mapping to
>>> fixmap for the page that is already mapped by kmap, It should be
>>> considered for the pkmap address in kmap_atomic_to_page.
>> What's the reasoning behind this change, given that I can find lots of
>> definitions of kmap_atomic_to_page() in the kernel, but not a single
>> user of this.
>>
>> If there's no users, should we be deleting this code?
> I think commit 5bbeed12bdc3 provides the answer to that question.
>
>
> Nicolas
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] ARM:mm: fix kmap_atomic_to_page Chanho Min <chanho.min@lge.com> - 2015-10-06 13:30 +0200
  Re: [PATCH] ARM:mm: fix kmap_atomic_to_page Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-06 21:30 +0200
    Re: [PATCH] ARM:mm: fix kmap_atomic_to_page Nicolas Pitre <nicolas.pitre@linaro.org> - 2015-10-07 03:40 +0200
      Re: [PATCH] ARM:mm: fix kmap_atomic_to_page Jongsung Kim <neidhard.kim@lge.com> - 2015-10-07 06:20 +0200
        Re: [PATCH] ARM:mm: fix kmap_atomic_to_page Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-07 11:10 +0200
          Re: [PATCH] ARM:mm: fix kmap_atomic_to_page Jongsung Kim <neidhard.kim@lge.com> - 2015-10-12 07:40 +0200
            Re: [PATCH] ARM:mm: fix kmap_atomic_to_page Arnd Bergmann <arnd@arndb.de> - 2015-10-12 11:30 +0200
              Re: [PATCH] ARM:mm: fix kmap_atomic_to_page Jongsung Kim <neidhard.kim@lge.com> - 2015-10-13 04:10 +0200
                Re: [PATCH] ARM:mm: fix kmap_atomic_to_page Arnd Bergmann <arnd@arndb.de> - 2015-10-13 13:50 +0200
  Re: [PATCH] ARM:mm: fix kmap_atomic_to_page yalin wang <yalin.wang2010@gmail.com> - 2015-10-12 08:10 +0200

csiph-web