Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1244387

Re: [PATCH] ARM:mm: fix kmap_atomic_to_page

Show all headers | View raw

We tried to utilize a HW compressor as a zram backend. Current zram uses kmap_atomic to map a page, and the HW DMAes. So we needed to use kmap_atomic_to_page to get the page to be dma-mapped.


On 10/07/2015 06:01 PM, Russell King - ARM Linux wrote:
> On Wed, Oct 07, 2015 at 12:55:08PM +0900, Jongsung Kim wrote:
>> Recently, we made a driver utilizing kmap_atomic_to_page. Of course,
>> it's not mainlined. People may be using it outside mainline just like us.
> Since kmap_atomic() mappings are supposed to be short-lived, why do you
> need it in your driver?  Don't you already have the struct page pointer
> when setting up the kmap_atomic() mapping?
>
> It is invalid to setup a mapping, and leave it setup across any context
> switching or similar.
>
> Also, kmap_atomic_to_page() is not exported to modules, so you can only
> use it when built-in.
>
>> vmalloc has vmalloc_to_page, pkmap has kmap_to page, and fixmap has
>> kmap_atomic_to_page. Then.. how about letting virt_to_page do them all?
> No.  virt_to_page() is defined to only work on the lowmem mapping, and
> that's not going to change.
>
> Please show the outline of your code making use of this function so we
> can better understand your use case.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM:mm: fix kmap_atomic_to_page Chanho Min <chanho.min@lge.com> - 2015-10-06 13:30 +0200
  Re: [PATCH] ARM:mm: fix kmap_atomic_to_page Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-06 21:30 +0200
    Re: [PATCH] ARM:mm: fix kmap_atomic_to_page Nicolas Pitre <nicolas.pitre@linaro.org> - 2015-10-07 03:40 +0200
      Re: [PATCH] ARM:mm: fix kmap_atomic_to_page Jongsung Kim <neidhard.kim@lge.com> - 2015-10-07 06:20 +0200
        Re: [PATCH] ARM:mm: fix kmap_atomic_to_page Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-07 11:10 +0200
          Re: [PATCH] ARM:mm: fix kmap_atomic_to_page Jongsung Kim <neidhard.kim@lge.com> - 2015-10-12 07:40 +0200
            Re: [PATCH] ARM:mm: fix kmap_atomic_to_page Arnd Bergmann <arnd@arndb.de> - 2015-10-12 11:30 +0200
              Re: [PATCH] ARM:mm: fix kmap_atomic_to_page Jongsung Kim <neidhard.kim@lge.com> - 2015-10-13 04:10 +0200
                Re: [PATCH] ARM:mm: fix kmap_atomic_to_page Arnd Bergmann <arnd@arndb.de> - 2015-10-13 13:50 +0200
  Re: [PATCH] ARM:mm: fix kmap_atomic_to_page yalin wang <yalin.wang2010@gmail.com> - 2015-10-12 08:10 +0200

csiph-web