Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1239327
| From | Andrzej Hajda <a.hajda@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 14/19] sony-laptop: fix handling sony_nc_hotkeys_decode result |
| Date | 2015-10-05 09:50 +0200 |
| Message-ID | <qg8GZ-Ta-5@gated-at.bofh.it> (permalink) |
| References | <qcfnH-5il-3@gated-at.bofh.it> <qcfnI-5il-27@gated-at.bofh.it> <qfyav-7uw-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 10/03/2015 06:39 PM, Darren Hart wrote:
> On Thu, Sep 24, 2015 at 04:00:22PM +0200, Andrzej Hajda wrote:
>> The function can return negative value.
>>
>> The problem has been detected using proposed semantic patch
>> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>>
>> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>>
>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Sorry for the delay Andrsej, and thank you for your patch. Given my delay, I've
> made a couple of changes myself rather than asking you to resubmit. Please
> review and let me know if you have any concerns.
Looks OK. Thanks for fixing.
Regards
Andrzej
>
> First, The description above is incomplete and relies on context from the URL
> to fully explain the problem you are fixing. In the future, please ensure the
> commit message is self-sufficient.
>
> I have changed the message to read:
>
> sony-laptop: Fix handling sony_nc_hotkeys_decode result
>
> sony_nv_hotkeys_decode can return a negative value. real_ev is a u32 variable.
> The check for real_ev > 0 is incorrect.
>
> Use an intermediate ret variable.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> [dvhart: clarify commit msg, drop superfluous else block]
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
>
> See below for an additional change.
>
>> ---
>> Hi,
>>
>> To avoid problems with too many mail recipients I have sent whole
>> patchset only to LKML. Anyway patches have no dependencies.
>>
>> Regards
>> Andrzej
>> ---
>> drivers/platform/x86/sony-laptop.c | 12 ++++++++----
>> 1 file changed, 8 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
>> index aeb80d1..d8a2115 100644
>> --- a/drivers/platform/x86/sony-laptop.c
>> +++ b/drivers/platform/x86/sony-laptop.c
>> @@ -1204,6 +1204,8 @@ static void sony_nc_notify(struct acpi_device *device, u32 event)
>> {
>> u32 real_ev = event;
>> u8 ev_type = 0;
>> + int ret;
>> +
>> dprintk("sony_nc_notify, event: 0x%.2x\n", event);
>>
>> if (event >= 0x90) {
>> @@ -1225,13 +1227,15 @@ static void sony_nc_notify(struct acpi_device *device, u32 event)
>> case 0x0100:
>> case 0x0127:
>> ev_type = HOTKEY;
>> - real_ev = sony_nc_hotkeys_decode(event, handle);
>> + ret = sony_nc_hotkeys_decode(event, handle);
>>
>> - if (real_ev > 0)
>> - sony_laptop_report_input_event(real_ev);
>> - else
>> + if (ret > 0) {
>> + sony_laptop_report_input_event(ret);
>> + real_ev = ret;
>> + } else {
>> /* restore the original event for reporting */
>> real_ev = event;
>> + }
> This 4 line else block is superfluous. real_ev is initialized to event and only changed here if ret > 0. Therefore, there is no need to set real_ev to event again. I have simply dropped the else block
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/19] Fixes related to incorrect assignment of signed results function Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
[PATCH 14/19] sony-laptop: fix handling sony_nc_hotkeys_decode result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
Re: [PATCH 14/19] sony-laptop: fix handling sony_nc_hotkeys_decode result Darren Hart <dvhart@infradead.org> - 2015-10-03 18:50 +0200
Re: [PATCH 14/19] sony-laptop: fix handling sony_nc_hotkeys_decode result Andrzej Hajda <a.hajda@samsung.com> - 2015-10-05 09:50 +0200
[PATCH 03/19] libata: samsung_cf: fix handling platform_get_irq result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
Re: [PATCH 03/19] libata: samsung_cf: fix handling platform_get_irq result Tejun Heo <tj@kernel.org> - 2015-09-24 17:00 +0200
[PATCH v2 03/19] libata: samsung_cf: fix handling platform_get_irq result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-25 08:50 +0200
Re: [PATCH v2 03/19] libata: samsung_cf: fix handling platform_get_irq result Tejun Heo <tj@kernel.org> - 2015-09-25 18:00 +0200
[PATCH 02/19] spi: davinci: fix handling platform_get_irq result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
[PATCH 07/19] net: hisilicon: fix handling platform_get_irq result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
Re: [PATCH 07/19] net: hisilicon: fix handling platform_get_irq result David Miller <davem@davemloft.net> - 2015-09-27 07:50 +0200
[PATCH 16/19] r8169: fix handling rtl_readphy result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
Re: [PATCH 16/19] r8169: fix handling rtl_readphy result David Miller <davem@davemloft.net> - 2015-09-27 07:50 +0200
[PATCH 18/19] mac80211: make ieee80211_new_mesh_header return unsigned Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
Re: [PATCH 18/19] mac80211: make ieee80211_new_mesh_header return unsigned Johannes Berg <johannes@sipsolutions.net> - 2015-09-24 16:20 +0200
[PATCH v2 18/19] mac80211: make ieee80211_new_mesh_header return unsigned Andrzej Hajda <a.hajda@samsung.com> - 2015-09-25 08:50 +0200
[PATCH 11/19] clocksource: fix __ftm_clk_init result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
[PATCH 17/19] tools: bpf_jit_disasm: make get_last_jit_image return unsigned Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
Re: [PATCH 17/19] tools: bpf_jit_disasm: make get_last_jit_image return unsigned Daniel Borkmann <daniel@iogearbox.net> - 2015-09-24 21:00 +0200
[PATCH v2 17/19] tools: bpf_jit_disasm: make get_last_jit_image return unsigned Andrzej Hajda <a.hajda@samsung.com> - 2015-09-25 08:50 +0200
Re: [PATCH v2 17/19] tools: bpf_jit_disasm: make get_last_jit_image return unsigned David Miller <davem@davemloft.net> - 2015-09-29 07:20 +0200
[PATCH 05/19] media: am437x-vpfe: fix handling platform_get_irq result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
[PATCH 13/19] extcon: sm5502: fix handling regmap_irq_get_virq result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
Re: [PATCH 13/19] extcon: sm5502: fix handling regmap_irq_get_virq result Chanwoo Choi <cw00.choi@samsung.com> - 2015-09-25 01:50 +0200
[PATCH 15/19] KVM: PPC: e500: fix handling local_sid_lookup result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
[PATCH 06/19] staging: media: omap4iss: fix handling platform_get_irq result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
Re: [PATCH 06/19] staging: media: omap4iss: fix handling platform_get_irq result Dan Carpenter <dan.carpenter@oracle.com> - 2015-09-24 17:10 +0200
[PATCH 09/19] dmaengine: xgene-dma: fix handling xgene_dma_get_ring_size result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
Re: [PATCH 09/19] dmaengine: xgene-dma: fix handling xgene_dma_get_ring_size result Vinod Koul <vinod.koul@intel.com> - 2015-09-25 04:10 +0200
csiph-web