Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1232127

[PATCH 09/19] dmaengine: xgene-dma: fix handling xgene_dma_get_ring_size result

Show all headers | View raw

The function can return negative value.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
Hi,

To avoid problems with too many mail recipients I have sent whole
patchset only to LKML. Anyway patches have no dependencies.

Regards
Andrzej
---
 drivers/dma/xgene-dma.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/xgene-dma.c b/drivers/dma/xgene-dma.c
index b23e8d5..c83ae75 100644
--- a/drivers/dma/xgene-dma.c
+++ b/drivers/dma/xgene-dma.c
@@ -1421,15 +1421,18 @@ static int xgene_dma_create_ring_one(struct xgene_dma_chan *chan,
 				     struct xgene_dma_ring *ring,
 				     enum xgene_dma_ring_cfgsize cfgsize)
 {
+	int ret;
+
 	/* Setup DMA ring descriptor variables */
 	ring->pdma = chan->pdma;
 	ring->cfgsize = cfgsize;
 	ring->num = chan->pdma->ring_num++;
 	ring->id = XGENE_DMA_RING_ID_GET(ring->owner, ring->buf_num);
 
-	ring->size = xgene_dma_get_ring_size(chan, cfgsize);
-	if (ring->size <= 0)
-		return ring->size;
+	ret = xgene_dma_get_ring_size(chan, cfgsize);
+	if (ret <= 0)
+			return ret;
+	ring->size = ret;
 
 	/* Allocate memory for DMA ring descriptor */
 	ring->desc_vaddr = dma_zalloc_coherent(chan->dev, ring->size,
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/19] Fixes related to incorrect assignment of signed results  function Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
  [PATCH 14/19] sony-laptop: fix handling sony_nc_hotkeys_decode result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
    Re: [PATCH 14/19] sony-laptop: fix handling sony_nc_hotkeys_decode  result Darren Hart <dvhart@infradead.org> - 2015-10-03 18:50 +0200
      Re: [PATCH 14/19] sony-laptop: fix handling sony_nc_hotkeys_decode  result Andrzej Hajda <a.hajda@samsung.com> - 2015-10-05 09:50 +0200
  [PATCH 03/19] libata: samsung_cf: fix handling platform_get_irq result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
    Re: [PATCH 03/19] libata: samsung_cf: fix handling platform_get_irq  result Tejun Heo <tj@kernel.org> - 2015-09-24 17:00 +0200
      [PATCH v2 03/19] libata: samsung_cf: fix handling platform_get_irq  result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-25 08:50 +0200
        Re: [PATCH v2 03/19] libata: samsung_cf: fix handling  platform_get_irq result Tejun Heo <tj@kernel.org> - 2015-09-25 18:00 +0200
  [PATCH 02/19] spi: davinci: fix handling platform_get_irq result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
  [PATCH 07/19] net: hisilicon: fix handling platform_get_irq result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
    Re: [PATCH 07/19] net: hisilicon: fix handling platform_get_irq  result David Miller <davem@davemloft.net> - 2015-09-27 07:50 +0200
  [PATCH 16/19] r8169: fix handling rtl_readphy result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
    Re: [PATCH 16/19] r8169: fix handling rtl_readphy result David Miller <davem@davemloft.net> - 2015-09-27 07:50 +0200
  [PATCH 18/19] mac80211: make ieee80211_new_mesh_header return unsigned Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
    Re: [PATCH 18/19] mac80211: make ieee80211_new_mesh_header return  unsigned Johannes Berg <johannes@sipsolutions.net> - 2015-09-24 16:20 +0200
      [PATCH v2 18/19] mac80211: make ieee80211_new_mesh_header return  unsigned Andrzej Hajda <a.hajda@samsung.com> - 2015-09-25 08:50 +0200
  [PATCH 11/19] clocksource: fix __ftm_clk_init result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
  [PATCH 17/19] tools: bpf_jit_disasm: make get_last_jit_image return  unsigned Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
    Re: [PATCH 17/19] tools: bpf_jit_disasm: make get_last_jit_image  return unsigned Daniel Borkmann <daniel@iogearbox.net> - 2015-09-24 21:00 +0200
      [PATCH v2 17/19] tools: bpf_jit_disasm: make get_last_jit_image return  unsigned Andrzej Hajda <a.hajda@samsung.com> - 2015-09-25 08:50 +0200
        Re: [PATCH v2 17/19] tools: bpf_jit_disasm: make  get_last_jit_image return unsigned David Miller <davem@davemloft.net> - 2015-09-29 07:20 +0200
  [PATCH 05/19] media: am437x-vpfe: fix handling platform_get_irq result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
  [PATCH 13/19] extcon: sm5502: fix handling regmap_irq_get_virq result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
    Re: [PATCH 13/19] extcon: sm5502: fix handling regmap_irq_get_virq  result Chanwoo Choi <cw00.choi@samsung.com> - 2015-09-25 01:50 +0200
  [PATCH 15/19] KVM: PPC: e500: fix handling local_sid_lookup result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
  [PATCH 06/19] staging: media: omap4iss: fix handling platform_get_irq  result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
    Re: [PATCH 06/19] staging: media: omap4iss: fix handling  platform_get_irq result Dan Carpenter <dan.carpenter@oracle.com> - 2015-09-24 17:10 +0200
  [PATCH 09/19] dmaengine: xgene-dma: fix handling  xgene_dma_get_ring_size result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
    Re: [PATCH 09/19] dmaengine: xgene-dma: fix handling  xgene_dma_get_ring_size result Vinod Koul <vinod.koul@intel.com> - 2015-09-25 04:10 +0200

csiph-web