Re: [PATCH 00/18] Input - Fix make coccicheck warnings

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 00/18] Input - Fix make coccicheck warnings
Date	2015-10-03 13:20 +0200
Message-ID	<qft18-cq-17@gated-at.bofh.it> (permalink)
References	<qf8SJ-4YE-7@gated-at.bofh.it> <qfdfI-2Wl-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Dmitry,

On 10/02/2015 08:25 PM, Dmitry Torokhov wrote:
> Hi Javier,
> 
> On Fri, Oct 02, 2015 at 03:40:11PM +0200, Javier Martinez Canillas wrote:
>> Hello Dmitry,
>>
>> This series contains trivial patches with fixes to different warnings
>> reported by make coccichek M=drivers/input.
>>
>> The patches don't contain functional changes but makes the functions
>> simpler and removes unnecessary lines of code.
> 
> I disagree with some "simplify function return logic" patches: when
> there are several actions that may fail I prefer explicit:
> 
> 	error = actionN();
> 	if (error)
> 		return error;
> 
> 	return 0;
> 
> even on the last one as it keep with the code flow and makes it easier
> to move stuff around.
>
> Please consider patches that not explicitly replied to as applied a
> dropped.

Thanks a lot for taking the time to explain this. I understand your
rationale and I tend to agree.

I'll see if the scripts/coccinelle/misc/simple_return.cocci semantic
patch can be modified to take this into account and not report a
warning for that pattern.

> 
> Thanks.
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 00/18] Input - Fix make coccicheck warnings Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-02 15:50 +0200
  [PATCH 14/18] Input: synaptics_i2c - simplify function return logic Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-02 15:50 +0200
  Re: [PATCH 00/18] Input - Fix make coccicheck warnings Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-02 20:30 +0200
    Re: [PATCH 00/18] Input - Fix make coccicheck warnings Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-03 13:20 +0200

csiph-web