Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1238278
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 14/18] Input: synaptics_i2c - simplify function return logic |
| Date | 2015-10-02 15:50 +0200 |
| Message-ID | <qf8SM-4YE-87@gated-at.bofh.it> (permalink) |
| References | <qf8SJ-4YE-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The invoked function already returns zero on success or a negative errno code so there is no need to open code the logic in the caller. This also fixes the following make coccicheck warnings: drivers/input/mouse/synaptics_i2c.c:298:1-4: WARNING: end returns can be simplified Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- drivers/input/mouse/synaptics_i2c.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/input/mouse/synaptics_i2c.c b/drivers/input/mouse/synaptics_i2c.c index aa7c5da60800..9f69ce3de2f3 100644 --- a/drivers/input/mouse/synaptics_i2c.c +++ b/drivers/input/mouse/synaptics_i2c.c @@ -295,11 +295,7 @@ static int synaptics_i2c_config(struct i2c_client *client) control |= reduce_report ? 1 << REDUCE_REPORTING : 0; /* No Filter */ control |= no_filter ? 1 << NO_FILTER : 0; - ret = synaptics_i2c_reg_set(client, GENERAL_2D_CONTROL_REG, control); - if (ret) - return ret; - - return 0; + return synaptics_i2c_reg_set(client, GENERAL_2D_CONTROL_REG, control); } static int synaptics_i2c_reset_config(struct i2c_client *client) -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/18] Input - Fix make coccicheck warnings Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-02 15:50 +0200
[PATCH 14/18] Input: synaptics_i2c - simplify function return logic Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-02 15:50 +0200
Re: [PATCH 00/18] Input - Fix make coccicheck warnings Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-02 20:30 +0200
Re: [PATCH 00/18] Input - Fix make coccicheck warnings Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-03 13:20 +0200
csiph-web