Re: [PATCH 1/3] Revert "dax: fix NULL pointer in __dax_pmd_fault()"

Path	csiph.com!goblin3!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From	Dan Williams <dan.j.williams@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] Revert "dax: fix NULL pointer in __dax_pmd_fault()"
Date	Fri, 02 Oct 2015 23:20:02 +0200
Message-ID	<qffUe-6LS-11@gated-at.bofh.it> (permalink)
References	<qffKx-6Av-3@gated-at.bofh.it> <qffKx-6Av-1@gated-at.bofh.it>
X-Original-To	Ross Zwisler <ross.zwisler@linux.intel.com>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=UWTUdpEqYj3VpGj2oxiU48loXzGa8WauQG7LXsU7aI0=; b=iaviwg1/UBveG1Nyb7g6K5QgCf6qq9WPx+WWZmcA2BLQ8bWo7R2xn8mSzIAjgywP0v JW382n8JVgf952+WSjSwStdgC/MZXQXWi4/x4GEiBLWhg67qoqbPSUEbq+lMm6peK7dG 1+s0Pqg3m1JwTyRdJuxVTX7J4udN+BK68R6lScV8bMlUPi6nlH6x87/N/1CNm18k9FVd xI6NkLbI7oQbRNvKgy9J3KhBHBCB+Pi1lT6DZWVv+I+QAY3r1f9MNrBVLPRcV/N3QsH2 LKfrQFcmn2wYqD+zuRr9iLNeSflHDczZsNMG8rUylcwBCiCvyRJePfYO6OcHqTalCqfF 8kQg==
X-Gm-Message-State	ALoCoQklAmkknZuC4h4dmQ3O2AbfgofWAGJ+oYv2Y5iLzJ/O43tiFoPf/7w46IrDPVpcGkgFFRag
MIME-Version	1.0
X-Received	by 10.194.78.34 with SMTP id y2mr18157349wjw.91.1443820263167; Fri, 02 Oct 2015 14:11:03 -0700 (PDT)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	21
Organization	linux.* mail to news gateway
X-Original-Cc	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Alexander Viro <viro@zeniv.linux.org.uk>, Matthew Wilcox <willy@linux.intel.com>, linux-fsdevel <linux-fsdevel@vger.kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Dave Chinner <dchinner@redhat.com>, Jan Kara <jack@suse.com>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
X-Original-Date	Fri, 2 Oct 2015 14:11:03 -0700
X-Original-Message-ID	<CAPcyv4jDuKnDat6keMpz0j-G3P4QTdTLm00+_=LE-GQLMR1x5w@mail.gmail.com>
X-Original-References	<1443819752-17091-1-git-send-email-ross.zwisler@linux.intel.com> <1443819752-17091-2-git-send-email-ross.zwisler@linux.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1238623

Show key headers only | View raw

On Fri, Oct 2, 2015 at 2:02 PM, Ross Zwisler
<ross.zwisler@linux.intel.com> wrote:
> This reverts commit 8346c416d17bf5b4ea1508662959bb62e73fd6a5.
>
> This commit did fix the issue it intended to fix, but it turns out that
> the locking changes introduced by these two commits:
>
> commit 843172978bb9 ("dax: fix race between simultaneous faults")
> commit 46c043ede471 ("mm: take i_mmap_lock in unmap_mapping_range() for DAX")
>
> had other issues as well, so they need to just be reverted.

Wait, why introduce two points in the kernel history where we have a
known uninitialized variable?  I'd say fix up the revert of "mm: take
i_mmap_lock in unmap_mapping_range() for DAX" to address the conflict
with the fix, one less patch and keeps the stability rolling forward.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 1/3] Revert "dax: fix NULL pointer in __dax_pmd_fault()" Ross Zwisler <ross.zwisler@linux.intel.com> - 2015-10-02 23:10 +0200
  Re: [PATCH 1/3] Revert "dax: fix NULL pointer in __dax_pmd_fault()" Dan Williams <dan.j.williams@intel.com> - 2015-10-02 23:20 +0200
    Re: [PATCH 1/3] Revert "dax: fix NULL pointer in __dax_pmd_fault()" Ross Zwisler <ross.zwisler@linux.intel.com> - 2015-10-03 01:30 +0200
      Re: [PATCH 1/3] Revert "dax: fix NULL pointer in __dax_pmd_fault()" Jan Kara <jack@suse.cz> - 2015-10-05 10:50 +0200

csiph-web