Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1238702
| From | Ross Zwisler <ross.zwisler@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/3] Revert "dax: fix NULL pointer in __dax_pmd_fault()" |
| Date | 2015-10-03 01:30 +0200 |
| Message-ID | <qfhW2-1bm-5@gated-at.bofh.it> (permalink) |
| References | <qffKx-6Av-3@gated-at.bofh.it> <qffKx-6Av-1@gated-at.bofh.it> <qffUe-6LS-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Oct 02, 2015 at 02:11:03PM -0700, Dan Williams wrote:
> On Fri, Oct 2, 2015 at 2:02 PM, Ross Zwisler
> <ross.zwisler@linux.intel.com> wrote:
> > This reverts commit 8346c416d17bf5b4ea1508662959bb62e73fd6a5.
> >
> > This commit did fix the issue it intended to fix, but it turns out that
> > the locking changes introduced by these two commits:
> >
> > commit 843172978bb9 ("dax: fix race between simultaneous faults")
> > commit 46c043ede471 ("mm: take i_mmap_lock in unmap_mapping_range() for DAX")
> >
> > had other issues as well, so they need to just be reverted.
>
> Wait, why introduce two points in the kernel history where we have a
> known uninitialized variable? I'd say fix up the revert of "mm: take
> i_mmap_lock in unmap_mapping_range() for DAX" to address the conflict
> with the fix, one less patch and keeps the stability rolling forward.
Essentially because I wasn't sure about the rules regarding reverts, if there
are any. I assumed (perhaps incorrectly) that you'd want a 1:1 relationship
between original commits and reverts. If it's better to not have intermediate
breakage, sure, let's squash them.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/3] Revert "dax: fix NULL pointer in __dax_pmd_fault()" Ross Zwisler <ross.zwisler@linux.intel.com> - 2015-10-02 23:10 +0200
Re: [PATCH 1/3] Revert "dax: fix NULL pointer in __dax_pmd_fault()" Dan Williams <dan.j.williams@intel.com> - 2015-10-02 23:20 +0200
Re: [PATCH 1/3] Revert "dax: fix NULL pointer in __dax_pmd_fault()" Ross Zwisler <ross.zwisler@linux.intel.com> - 2015-10-03 01:30 +0200
Re: [PATCH 1/3] Revert "dax: fix NULL pointer in __dax_pmd_fault()" Jan Kara <jack@suse.cz> - 2015-10-05 10:50 +0200
csiph-web