Re: [PATCH 4/4] nvmem: sunxi: Check for memory allocation failure

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] nvmem: sunxi: Check for memory allocation failure
Date	Sun, 04 Oct 2015 16:50:01 +0200
Message-ID	<qfSLT-3gH-9@gated-at.bofh.it> (permalink)
References	<qeoPU-54G-11@gated-at.bofh.it> <qeoPU-54G-9@gated-at.bofh.it> <qfPkZ-6Z8-11@gated-at.bofh.it>
X-Original-To	Greg KH <gregkh@linuxfoundation.org>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=zk1Vu00LeVo3Y4rZpAhx6Q0V0wanrX9m9qJRcdPEiiw=; b=Y/wpenfbVgMO0vNnDWk3MeXRXUFLyYY44MofuIuTZu4RRWU1x8lxYLT1gUrZD+zZ2c Q+yFHskaLb2pjtsPR/5V0vP0/8q728MiBWlgb1hqKX6jkc/iYVstoCD7tXy5XZU3CvsE ZnOO4GVIN6BpagfUNIl9p64DnPVglyTfnQl1XqIvFDxkfptXDOxFzKq0gRAc9nfnrAFs q87WFSMAyCGn4Mb1I0X6qoA9cwoDEuhDauHD0KuKsOgNiywxLslIicI8bHXjEdUP0wEv nzcTwJMIveZLnHRPyk+t6ajQUGSgsN03h+A5H1KZNlUBxRp2U5mHvzpnbLrZBaUDNUrK 1Etg==
X-Gm-Message-State	ALoCoQk9/vSO65n4Xgtunr/OAXyKXB1N4JtwnyV+TK4wbb0UzsNZUW5Sm9XEVUCXFiaCj1epq5jt
X-Received	by 10.180.105.138 with SMTP id gm10mr6250479wib.37.1443969658117; Sun, 04 Oct 2015 07:40:58 -0700 (PDT)
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	maxime.ripard@free-electrons.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
X-Original-Date	Sun, 04 Oct 2015 15:40:52 +0100
X-Original-Message-ID	<56113A74.1090407@linaro.org>
X-Original-References	<1443616298-17389-1-git-send-email-srinivas.kandagatla@linaro.org> <1443616591-17867-1-git-send-email-srinivas.kandagatla@linaro.org> <20151004110421.GB7110@kroah.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1239133

Show key headers only | View raw


On 04/10/15 12:04, Greg KH wrote:
> On Wed, Sep 30, 2015 at 01:36:31PM +0100, Srinivas Kandagatla wrote:
>> From: Maxime Ripard <maxime.ripard@free-electrons.com>
>>
>> The sunxi_sid driver doesn't check for kmalloc return status before
>> derefencing the returned pointer, which could lead to a NULL pointer
>> dereference if kmalloc failed. Check for its return code to make sure it
>> deosn't happen.
>>
>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>> ---
>>   drivers/nvmem/sunxi_sid.c | 11 ++++++++++-
>>   1 file changed, 10 insertions(+), 1 deletion(-)
>
> No signed-off-by: from you on this patch?
>

Oops!! My bad I missed the sign-off.

Thanks for taking this patch, I will make sure I will recheck this 
before sending.

--srini

> :(
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/4] nvmem: sunxi: Check for memory allocation failure Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-09-30 14:40 +0200
  Re: [PATCH 4/4] nvmem: sunxi: Check for memory allocation failure Greg KH <gregkh@linuxfoundation.org> - 2015-10-04 13:10 +0200
    Re: [PATCH 4/4] nvmem: sunxi: Check for memory allocation failure Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-10-04 16:50 +0200

csiph-web