Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1238109

Re: [PATCH] input: gpio_keys: Don't report events on gpio failure

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] input: gpio_keys: Don't report events on gpio failure
Date Fri, 02 Oct 2015 12:40:02 +0200
Message-ID <qf5US-LE-13@gated-at.bofh.it> (permalink)
References <pR2ls-36Q-11@gated-at.bofh.it>
X-Original-To Bjorn Andersson <bjorn.andersson@sonymobile.com>
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=+M/ZcAXM7ocQK6gRzhBxkWgLc5zOSWsWUf/mcmX/5JI=; b=avcYZBCu+C7npvMCKa2Nrye9eGxKHYAxKlWdDfFAWXsuuLAL/6W1m+H6avthUtrK8h La7nnjIinsgQzPlJSkQL3bPizy8tDjmmFsLnmSHV+H5IqLMcNBI7+yQaYKkn09vhJ/z0 EPJ7kdyok7oSBG5d6TWggBDLp6fr3272fX7gOQZgUO3AXhuNs8Xomx7ByE0LD8DWLoic swhrtnN5ltmqyvOgjepcK15+/t7iU+UCID1yF+zDlke8S7cMZBuD2c29j/EOxWx4dDDQ A44std+6WPCiQDaZjIPyBsaIKbu/T5TjT2EF6t9Q8aDsAYu8M1Di+Xy7vjNP/d9hZOX3 2YXQ==
X-Gm-Message-State ALoCoQmfNRerVQi1MC6KQJ81tXBp6EvD3q87lv4jz5cm2XSuZd6FS1kMMGQEAXdyl5m7RH4KPQJR
MIME-Version 1.0
X-Received by 10.202.205.133 with SMTP id d127mr8634474oig.9.1443782085804; Fri, 02 Oct 2015 03:34:45 -0700 (PDT)
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 22
Organization linux.* mail to news gateway
X-Original-Cc Dmitry Torokhov <dmitry.torokhov@gmail.com>, Linux Input <linux-input@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, John Stultz <john.stultz@linaro.org>
X-Original-Date Fri, 2 Oct 2015 03:34:45 -0700
X-Original-Message-ID <CACRpkdaCFgNpHcK9q_rbA5igE3vAnQJeAOkYB0c+a_Grwy2NUA@mail.gmail.com>
X-Original-References <1438048204-632-1-git-send-email-bjorn.andersson@sonymobile.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1238109

Show key headers only | View raw


On Mon, Jul 27, 2015 at 6:50 PM, Bjorn Andersson
<bjorn.andersson@sonymobile.com> wrote:

> In the cases where the gpio chip fails to acquire the current state an
> error is reported back to gpio_keys. This is currently interpreted as if
> the line went high, which just confuses the developer.
>
> This patch introduces an error print in this case and skipps the
> reporting of a input event; to aid in debugging this issue.
>
> Reported-by: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH] input: gpio_keys: Don't report events on gpio failure Linus Walleij <linus.walleij@linaro.org> - 2015-10-02 12:40 +0200
  Re: [PATCH] input: gpio_keys: Don't report events on gpio failure Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-02 19:50 +0200

csiph-web