Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1238109

Re: [PATCH] input: gpio_keys: Don't report events on gpio failure

Show all headers | View raw

On Mon, Jul 27, 2015 at 6:50 PM, Bjorn Andersson
<bjorn.andersson@sonymobile.com> wrote:

> In the cases where the gpio chip fails to acquire the current state an
> error is reported back to gpio_keys. This is currently interpreted as if
> the line went high, which just confuses the developer.
>
> This patch introduces an error print in this case and skipps the
> reporting of a input event; to aid in debugging this issue.
>
> Reported-by: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] input: gpio_keys: Don't report events on gpio failure Linus Walleij <linus.walleij@linaro.org> - 2015-10-02 12:40 +0200
  Re: [PATCH] input: gpio_keys: Don't report events on gpio failure Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-02 19:50 +0200

csiph-web