Re: [PATCH 4/4] net: phy: Broadcom Cygnus internal Etherent PHY driver

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Arun Parameswaran <aparames@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] net: phy: Broadcom Cygnus internal Etherent PHY driver
Date	Wed, 30 Sep 2015 23:50:02 +0200
Message-ID	<qexqa-AE-15@gated-at.bofh.it> (permalink)
References	<qewkp-7rR-5@gated-at.bofh.it> <qewkq-7rR-23@gated-at.bofh.it> <qexgt-oR-11@gated-at.bofh.it>
X-Original-To	Florian Fainelli <f.fainelli@gmail.com>, Arun Parameswaran <arunp@broadcom.com>
X-Ironport-Av	E=Sophos;i="5.17,614,1437462000"; d="scan'208";a="76295660"
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version	1.0
Content-Type	text/plain; charset="utf-8"
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
Organization	linux.* mail to news gateway
X-Original-Cc	"David S. Miller" <davem@davemloft.net>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>
X-Original-Date	Wed, 30 Sep 2015 14:43:05 -0700
X-Original-Message-ID	<560C5769.4070607@broadcom.com>
X-Original-References	<1443645163-2822-1-git-send-email-arunp@broadcom.com> <1443645163-2822-5-git-send-email-arunp@broadcom.com> <560C5633.5080203@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1236795

Show key headers only | View raw


On 15-09-30 02:37 PM, Florian Fainelli wrote:
> On 30/09/15 13:32, Arun Parameswaran wrote:
>> Add support for the Broadcom Cygnus SoCs internal PHY's.
>> The PHYs are 1000M/100M/10M capable with support for 'EEE'
>> and 'APD' (Auto Power Down).
>>
>> This driver supports the following Broadcom Cygnus SoCs:
>>  - BCM583XX (BCM58300, BCM58302, BCM58303, BCM58305)
>>  - BCM113XX (BCM11300, BCM11320, BCM11350, BCM11360)
>>
>> The PHY's on these SoC's require some workarounds for
>> stable operation, both during configuration time and
>> during suspend/resume. This driver handles the
>> application of the workarounds.
>>
>> Signed-off-by: Arun Parameswaran <arunp@broadcom.com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>
> Some suggestions if you need to respin this patch series below, sorry
> for not catching that during the internal review:
>
>> +/* Broadcom Cygnus Phy specific registers */
>> +#define MII_BCM_CORE_BASE1E       0x1E /* Core BASE1E register */
>> +#define MII_BCM_EXPB0             0xB0 /* EXPB0 register */
>> +#define MII_BCM_EXPB1             0xB1 /* EXPB1 register */
> These defines could be moved to brcmphy.h for instance, since they are
> shared between all Broadcom PHY drivers AFAICT.

Ok, Will move these and modify the corresponding PHY drivers.

Thanks,
Arun


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/4] Add support for Broadcom's iProc MDIO and Cygnus Ethernet PHY Arun Parameswaran <arunp@broadcom.com> - 2015-09-30 22:40 +0200
  [PATCH 4/4] net: phy: Broadcom Cygnus internal Etherent PHY driver Arun Parameswaran <arunp@broadcom.com> - 2015-09-30 22:40 +0200
    Re: [PATCH 4/4] net: phy: Broadcom Cygnus internal Etherent PHY driver Florian Fainelli <f.fainelli@gmail.com> - 2015-09-30 23:40 +0200
      Re: [PATCH 4/4] net: phy: Broadcom Cygnus internal Etherent PHY driver Arun Parameswaran <aparames@broadcom.com> - 2015-09-30 23:50 +0200
  [PATCH 1/4] dt-bindings: net: Broadcom iProc MDIO bus driver device tree binding Arun Parameswaran <arunp@broadcom.com> - 2015-09-30 22:40 +0200
    Re: [PATCH 1/4] dt-bindings: net: Broadcom iProc MDIO bus driver  device tree binding Florian Fainelli <f.fainelli@gmail.com> - 2015-09-30 23:40 +0200
      Re: [PATCH 1/4] dt-bindings: net: Broadcom iProc MDIO bus driver  device tree binding Arun Parameswaran <aparames@broadcom.com> - 2015-09-30 23:50 +0200
  [PATCH 2/4] net: phy: Broadcom iProc MDIO bus driver Arun Parameswaran <arunp@broadcom.com> - 2015-09-30 22:40 +0200
    Re: [PATCH 2/4] net: phy: Broadcom iProc MDIO bus driver Florian Fainelli <f.fainelli@gmail.com> - 2015-09-30 23:40 +0200
  [PATCH 3/4] net: phy: Add Broadcom phy library for common interfaces Arun Parameswaran <arunp@broadcom.com> - 2015-09-30 22:40 +0200
    Re: [PATCH 3/4] net: phy: Add Broadcom phy library for common  interfaces kbuild test robot <lkp@intel.com> - 2015-09-30 23:20 +0200
    Re: [PATCH 3/4] net: phy: Add Broadcom phy library for common interfaces Florian Fainelli <f.fainelli@gmail.com> - 2015-09-30 23:40 +0200

csiph-web