Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1236781

Re: [PATCH 4/4] net: phy: Broadcom Cygnus internal Etherent PHY driver

Show all headers | View raw

On 30/09/15 13:32, Arun Parameswaran wrote:
> Add support for the Broadcom Cygnus SoCs internal PHY's.
> The PHYs are 1000M/100M/10M capable with support for 'EEE'
> and 'APD' (Auto Power Down).
> 
> This driver supports the following Broadcom Cygnus SoCs:
>  - BCM583XX (BCM58300, BCM58302, BCM58303, BCM58305)
>  - BCM113XX (BCM11300, BCM11320, BCM11350, BCM11360)
> 
> The PHY's on these SoC's require some workarounds for
> stable operation, both during configuration time and
> during suspend/resume. This driver handles the
> application of the workarounds.
> 
> Signed-off-by: Arun Parameswaran <arunp@broadcom.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Some suggestions if you need to respin this patch series below, sorry
for not catching that during the internal review:

> +/* Broadcom Cygnus Phy specific registers */
> +#define MII_BCM_CORE_BASE1E       0x1E /* Core BASE1E register */
> +#define MII_BCM_EXPB0             0xB0 /* EXPB0 register */
> +#define MII_BCM_EXPB1             0xB1 /* EXPB1 register */

These defines could be moved to brcmphy.h for instance, since they are
shared between all Broadcom PHY drivers AFAICT.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] Add support for Broadcom's iProc MDIO and Cygnus Ethernet PHY Arun Parameswaran <arunp@broadcom.com> - 2015-09-30 22:40 +0200
  [PATCH 4/4] net: phy: Broadcom Cygnus internal Etherent PHY driver Arun Parameswaran <arunp@broadcom.com> - 2015-09-30 22:40 +0200
    Re: [PATCH 4/4] net: phy: Broadcom Cygnus internal Etherent PHY driver Florian Fainelli <f.fainelli@gmail.com> - 2015-09-30 23:40 +0200
      Re: [PATCH 4/4] net: phy: Broadcom Cygnus internal Etherent PHY driver Arun Parameswaran <aparames@broadcom.com> - 2015-09-30 23:50 +0200
  [PATCH 1/4] dt-bindings: net: Broadcom iProc MDIO bus driver device tree binding Arun Parameswaran <arunp@broadcom.com> - 2015-09-30 22:40 +0200
    Re: [PATCH 1/4] dt-bindings: net: Broadcom iProc MDIO bus driver  device tree binding Florian Fainelli <f.fainelli@gmail.com> - 2015-09-30 23:40 +0200
      Re: [PATCH 1/4] dt-bindings: net: Broadcom iProc MDIO bus driver  device tree binding Arun Parameswaran <aparames@broadcom.com> - 2015-09-30 23:50 +0200
  [PATCH 2/4] net: phy: Broadcom iProc MDIO bus driver Arun Parameswaran <arunp@broadcom.com> - 2015-09-30 22:40 +0200
    Re: [PATCH 2/4] net: phy: Broadcom iProc MDIO bus driver Florian Fainelli <f.fainelli@gmail.com> - 2015-09-30 23:40 +0200
  [PATCH 3/4] net: phy: Add Broadcom phy library for common interfaces Arun Parameswaran <arunp@broadcom.com> - 2015-09-30 22:40 +0200
    Re: [PATCH 3/4] net: phy: Add Broadcom phy library for common  interfaces kbuild test robot <lkp@intel.com> - 2015-09-30 23:20 +0200
    Re: [PATCH 3/4] net: phy: Add Broadcom phy library for common interfaces Florian Fainelli <f.fainelli@gmail.com> - 2015-09-30 23:40 +0200

csiph-web