Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1236708

Re: [PATCH] HID: hiddev: fix returned errno code in hiddev_connect()

Show all headers | View raw

On Wed, 30 Sep 2015, Luis de Bethencourt wrote:

> The driver is using -1 instead of the -ENOMEM defined macro to specify
> that a buffer allocation failed. Since the error number is propagated,
> the caller will get a -EPERM which is the wrong error condition.

Generally I agree that the more specific errno, the better.

But I am not really sure where you are seeing the bug (mapping to -EPERM) 
in this case? I think the only caller of hiddev_connect() should be 
hid_connect(), and the only thing that guy cares about whether individual 
callbacks succeed or fail, so that it sets hdev->clamed flags accordingly.

Could you please be more specific about the -EPERM mapping you are talking 
about?

Thanks,

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] HID: hiddev: fix returned errno code in hiddev_connect() Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-09-30 12:30 +0200
  Re: [PATCH] HID: hiddev: fix returned errno code in  hiddev_connect() Jiri Kosina <jikos@kernel.org> - 2015-09-30 21:50 +0200
    Re: [PATCH] HID: hiddev: fix returned errno code in hiddev_connect() Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-10-03 23:40 +0200
      Re: [PATCH] HID: hiddev: fix returned errno code in  hiddev_connect() Jiri Kosina <jikos@kernel.org> - 2015-10-05 16:30 +0200

csiph-web