Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1236056

[PATCH] HID: hiddev: fix returned errno code in hiddev_connect()

Show all headers | View raw

The driver is using -1 instead of the -ENOMEM defined macro to specify
that a buffer allocation failed. Since the error number is propagated,
the caller will get a -EPERM which is the wrong error condition.

Also, the smatch tool complains with the following warning:
hiddev_connect() warn: returning -1 instead of -ENOMEM is sloppy

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
 drivers/hid/usbhid/hiddev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
index 2f1ddca..c5290ff 100644
--- a/drivers/hid/usbhid/hiddev.c
+++ b/drivers/hid/usbhid/hiddev.c
@@ -894,7 +894,7 @@ int hiddev_connect(struct hid_device *hid, unsigned int force)
 	}
 
 	if (!(hiddev = kzalloc(sizeof(struct hiddev), GFP_KERNEL)))
-		return -1;
+		return -ENOMEM;
 
 	init_waitqueue_head(&hiddev->wait);
 	INIT_LIST_HEAD(&hiddev->list);
-- 
2.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] HID: hiddev: fix returned errno code in hiddev_connect() Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-09-30 12:30 +0200
  Re: [PATCH] HID: hiddev: fix returned errno code in  hiddev_connect() Jiri Kosina <jikos@kernel.org> - 2015-09-30 21:50 +0200
    Re: [PATCH] HID: hiddev: fix returned errno code in hiddev_connect() Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-10-03 23:40 +0200
      Re: [PATCH] HID: hiddev: fix returned errno code in  hiddev_connect() Jiri Kosina <jikos@kernel.org> - 2015-10-05 16:30 +0200

csiph-web