Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1236641
| From | Rasmus Villemoes <linux@rasmusvillemoes.dk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 3/3] regmap: debugfs: simplify regmap_reg_ranges_read_file() slightly |
| Date | 2015-09-30 20:40 +0200 |
| Message-ID | <qeusi-4KD-41@gated-at.bofh.it> (permalink) |
| References | <qdP5L-4q2-9@gated-at.bofh.it> <qeush-4KD-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
By printing the newline character to entry, we can avoid accounting
for it manually in several places.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/base/regmap/regmap-debugfs.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c
index bed690740efa..df0d2cd60e39 100644
--- a/drivers/base/regmap/regmap-debugfs.c
+++ b/drivers/base/regmap/regmap-debugfs.c
@@ -367,17 +367,15 @@ static ssize_t regmap_reg_ranges_read_file(struct file *file,
p = 0;
mutex_lock(&map->cache_lock);
list_for_each_entry(c, &map->debugfs_off_cache, list) {
- entry_len = snprintf(entry, PAGE_SIZE, "%x-%x",
+ entry_len = snprintf(entry, PAGE_SIZE, "%x-%x\n",
c->base_reg, c->max_reg);
if (p >= *ppos) {
- if (buf_pos + 1 + entry_len > count)
+ if (buf_pos + entry_len > count)
break;
memcpy(buf + buf_pos, entry, entry_len);
buf_pos += entry_len;
- buf[buf_pos] = '\n';
- buf_pos++;
}
- p += entry_len + 1;
+ p += entry_len;
}
mutex_unlock(&map->cache_lock);
--
2.1.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] regmap: debugfs: remove bogus check Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-29 00:30 +0200
[PATCH 2/2] regmap: debugfs: improve regmap_reg_ranges_read_file() Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-29 00:30 +0200
Re: [PATCH 2/2] regmap: debugfs: improve regmap_reg_ranges_read_file() Mark Brown <broonie@kernel.org> - 2015-09-29 20:40 +0200
Re: [PATCH 2/2] regmap: debugfs: improve regmap_reg_ranges_read_file() Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-30 12:00 +0200
Re: [PATCH 2/2] regmap: debugfs: improve regmap_reg_ranges_read_file() Mark Brown <broonie@kernel.org> - 2015-09-30 19:20 +0200
[PATCH v2 2/3] regmap: debugfs: use memcpy instead of snprintf Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-30 20:40 +0200
[PATCH v2 3/3] regmap: debugfs: simplify regmap_reg_ranges_read_file() slightly Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-30 20:40 +0200
[PATCH v2 1/3] regmap: debugfs: use snprintf return value in regmap_reg_ranges_read_file() Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-30 20:40 +0200
Re: [PATCH 1/2] regmap: debugfs: remove bogus check Mark Brown <broonie@kernel.org> - 2015-09-29 20:20 +0200
Re: [PATCH 1/2] regmap: debugfs: remove bogus check Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-30 09:30 +0200
Re: [PATCH 1/2] regmap: debugfs: remove bogus check Mark Brown <broonie@kernel.org> - 2015-09-30 19:30 +0200
Re: [PATCH 1/2] regmap: debugfs: remove bogus check Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-30 20:00 +0200
Re: [PATCH 1/2] regmap: debugfs: remove bogus check Mark Brown <broonie@kernel.org> - 2015-09-30 20:20 +0200
csiph-web