Re: [PATCH 2/2] regmap: debugfs: improve regmap_reg_ranges_read_file()

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] regmap: debugfs: improve regmap_reg_ranges_read_file()
Date	2015-09-30 19:20 +0200
Message-ID	<qetcS-327-3@gated-at.bofh.it> (permalink)
References	<qdP5L-4q2-3@gated-at.bofh.it> <qdP5L-4q2-9@gated-at.bofh.it> <qe7YL-6an-43@gated-at.bofh.it> <qeml9-1mP-63@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Sep 30, 2015 at 11:51:33AM +0200, Rasmus Villemoes wrote:
> On Tue, Sep 29 2015, Mark Brown <broonie@kernel.org> wrote:
> > On Tue, Sep 29, 2015 at 12:29:02AM +0200, Rasmus Villemoes wrote:

> > That said I think memcpy() is going to be the best way of getting to
> > that since one of the issues there (which currently doesn't work) is
> > slicing things off the front and memcpy() handles that nicely.

> I'm not sure I understand what you want to do. Should I resend as three
> separate patches (the four bullets minus the PAGE_SIZE thing), and then
> we can take it from there?

I'd like to while we're at optimising the code to make it more
functional by supporting copying out any chunk of data rather than just
complete lines as now.

In any case, please split up and resend as you suggest above.

Thread

[PATCH 1/2] regmap: debugfs: remove bogus check Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-29 00:30 +0200
  [PATCH 2/2] regmap: debugfs: improve regmap_reg_ranges_read_file() Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-29 00:30 +0200
    Re: [PATCH 2/2] regmap: debugfs: improve  regmap_reg_ranges_read_file() Mark Brown <broonie@kernel.org> - 2015-09-29 20:40 +0200
      Re: [PATCH 2/2] regmap: debugfs: improve regmap_reg_ranges_read_file() Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-30 12:00 +0200
        Re: [PATCH 2/2] regmap: debugfs: improve  regmap_reg_ranges_read_file() Mark Brown <broonie@kernel.org> - 2015-09-30 19:20 +0200
    [PATCH v2 2/3] regmap: debugfs: use memcpy instead of snprintf Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-30 20:40 +0200
    [PATCH v2 3/3] regmap: debugfs: simplify regmap_reg_ranges_read_file() slightly Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-30 20:40 +0200
    [PATCH v2 1/3] regmap: debugfs: use snprintf return value in regmap_reg_ranges_read_file() Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-30 20:40 +0200
  Re: [PATCH 1/2] regmap: debugfs: remove bogus check Mark Brown <broonie@kernel.org> - 2015-09-29 20:20 +0200
    Re: [PATCH 1/2] regmap: debugfs: remove bogus check Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-30 09:30 +0200
      Re: [PATCH 1/2] regmap: debugfs: remove bogus check Mark Brown <broonie@kernel.org> - 2015-09-30 19:30 +0200
        Re: [PATCH 1/2] regmap: debugfs: remove bogus check Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-30 20:00 +0200
          Re: [PATCH 1/2] regmap: debugfs: remove bogus check Mark Brown <broonie@kernel.org> - 2015-09-30 20:20 +0200

csiph-web