Re: [PATCH] x86: Fix thermal throttling reporting after kexec

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Andi Kleen <ak@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86: Fix thermal throttling reporting after kexec
Date	Fri, 02 Oct 2015 00:10:02 +0200
Message-ID	<qeUd4-Rt-31@gated-at.bofh.it> (permalink)
References	<qcl9M-55S-9@gated-at.bofh.it> <qeL06-3Kc-13@gated-at.bofh.it> <qePQ6-2MU-15@gated-at.bofh.it> <qeTTI-eK-21@gated-at.bofh.it> <qeU3o-qz-9@gated-at.bofh.it>
X-Original-To	Andi Kleen <andi@firstfloor.org>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.17,619,1437462000"; d="scan'208";a="817524580"
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	Thomas Gleixner <tglx@linutronix.de>, x86@kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 1 Oct 2015 15:04:57 -0700
X-Original-Message-ID	<20151001220457.GD26924@tassilo.jf.intel.com>
X-Original-References	<1443125443-24691-1-git-send-email-andi@firstfloor.org> <alpine.DEB.2.11.1510011413151.4500@nanos> <20151001172737.GC26924@tassilo.jf.intel.com> <alpine.DEB.2.11.1510012339500.4500@nanos> <20151001214959.GF12732@two.firstfloor.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1237776

Show key headers only | View raw

On Thu, Oct 01, 2015 at 11:50:00PM +0200, Andi Kleen wrote:
> > I see it under the correctness aspect. Mop up before you shut down.
> 
> Ok. I suspect if you want to clean up all registers there's much more
> to do.
> 
> BTW there's a small danger in it: if we ever crash accessing on
> of those registers panic may end up looping.

I thought more about it. Since this is per logical CPU state
the cleanup cannot be done in a normal shutdown callback (which
only runs on one CPU), but needs some kind of global IPI/NMI.

IPI could deadlock, so it would need to be NMI.

KVM already has one, but would need to re-organize that into
first into a generic callback infrastructure.

I don't think so much change is worth it for this one
somewhat dubious case. NMI code is also tricky and it's
probably better to keep the shut down paths as simple
and reliable as possible. Do you agree?

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] x86: Fix thermal throttling reporting after kexec Andi Kleen <andi@firstfloor.org> - 2015-09-24 22:20 +0200
  Re: [PATCH] x86: Fix thermal throttling reporting after kexec Thomas Gleixner <tglx@linutronix.de> - 2015-10-01 14:20 +0200
    Re: [PATCH] x86: Fix thermal throttling reporting after kexec Andi Kleen <ak@linux.intel.com> - 2015-10-01 19:30 +0200
      Re: [PATCH] x86: Fix thermal throttling reporting after kexec Thomas Gleixner <tglx@linutronix.de> - 2015-10-01 23:50 +0200
        Re: [PATCH] x86: Fix thermal throttling reporting after kexec Andi Kleen <andi@firstfloor.org> - 2015-10-02 00:00 +0200
          Re: [PATCH] x86: Fix thermal throttling reporting after kexec Andi Kleen <ak@linux.intel.com> - 2015-10-02 00:10 +0200
            Re: [PATCH] x86: Fix thermal throttling reporting after kexec Thomas Gleixner <tglx@linutronix.de> - 2015-10-02 22:40 +0200

csiph-web