Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1237360

Re: [PATCH] x86: Fix thermal throttling reporting after kexec

Show all headers | View raw

On Thu, 24 Sep 2015, Andi Kleen wrote:
> The per CPU thermal vector init code checks if the thermal
> vector is already installed and complains and bails out if
> it is.
> 
> This happens after kexec, as kernel shut down does
> not clear the thermal vector APIC register.

So the obvious question is, why don't we do that.

> Just remove the check. I checked the code and there's
> no valid code paths where the thermal init code for a CPU
> could be called multiple times.

I'm not against removing that check as it does not really add value,
but we still should clear the APIC register at shut down, right?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86: Fix thermal throttling reporting after kexec Andi Kleen <andi@firstfloor.org> - 2015-09-24 22:20 +0200
  Re: [PATCH] x86: Fix thermal throttling reporting after kexec Thomas Gleixner <tglx@linutronix.de> - 2015-10-01 14:20 +0200
    Re: [PATCH] x86: Fix thermal throttling reporting after kexec Andi Kleen <ak@linux.intel.com> - 2015-10-01 19:30 +0200
      Re: [PATCH] x86: Fix thermal throttling reporting after kexec Thomas Gleixner <tglx@linutronix.de> - 2015-10-01 23:50 +0200
        Re: [PATCH] x86: Fix thermal throttling reporting after kexec Andi Kleen <andi@firstfloor.org> - 2015-10-02 00:00 +0200
          Re: [PATCH] x86: Fix thermal throttling reporting after kexec Andi Kleen <ak@linux.intel.com> - 2015-10-02 00:10 +0200
            Re: [PATCH] x86: Fix thermal throttling reporting after kexec Thomas Gleixner <tglx@linutronix.de> - 2015-10-02 22:40 +0200

csiph-web