Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1237724
| From | Ben Hutchings <ben@decadent.org.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] x86: uapi: Fix __BITS_PER_LONG for x32 |
| Date | 2015-10-01 23:00 +0200 |
| Message-ID | <qeT7k-7th-7@gated-at.bofh.it> (permalink) |
| References | <qeAel-4BU-3@gated-at.bofh.it> <qeHpx-6S6-23@gated-at.bofh.it> <qeLMv-53B-33@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Thu, 2015-10-01 at 09:02 -0400, Brian Gerst wrote: > On Thu, Oct 1, 2015 at 4:23 AM, Ingo Molnar <mingo@kernel.org> wrote: > > > > * Ben Hutchings <ben@decadent.org.uk> wrote: > > > > > diff --git a/arch/x86/include/uapi/asm/bitsperlong.h > > > b/arch/x86/include/uapi/asm/bitsperlong.h > > > index b0ae1c4..217909b 100644 > > > --- a/arch/x86/include/uapi/asm/bitsperlong.h > > > +++ b/arch/x86/include/uapi/asm/bitsperlong.h > > > @@ -1,7 +1,7 @@ > > > #ifndef __ASM_X86_BITSPERLONG_H > > > #define __ASM_X86_BITSPERLONG_H > > > > > > -#ifdef __x86_64__ > > > +#if defined(__x86_64__) && !defined(__ILP32__) > > > # define __BITS_PER_LONG 64 > > > > Can we write this as: > > > > #ifdef __ILP64__ Assuming you meant __LP64__... > Do all versions of gcc/clang define that, even if x32 isn't > supported? For gcc, it's been defined since 2003 (gcc 3.3): https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=0bdab2d89e28ca4dc84f8f0fafed85a4822bca49 For clang, it's been defined since before its first public release: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?r1=38978&r2=38987&pathrev=161685 So gcc 3.1 and 3.2 didn't define it, but everything newer does. Ben. -- Ben Hutchings Knowledge is power. France is bacon.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] x86: uapi: Fix __BITS_PER_LONG for x32 Ben Hutchings <ben@decadent.org.uk> - 2015-10-01 02:50 +0200
Re: [PATCH] x86: uapi: Fix __BITS_PER_LONG for x32 Ingo Molnar <mingo@kernel.org> - 2015-10-01 10:30 +0200
Re: [PATCH] x86: uapi: Fix __BITS_PER_LONG for x32 Brian Gerst <brgerst@gmail.com> - 2015-10-01 15:10 +0200
Re: [PATCH] x86: uapi: Fix __BITS_PER_LONG for x32 Ben Hutchings <ben@decadent.org.uk> - 2015-10-01 23:00 +0200
Re: [PATCH] x86: uapi: Fix __BITS_PER_LONG for x32 Ben Hutchings <ben@decadent.org.uk> - 2015-10-02 04:00 +0200
[tip:x86/urgent] x86/headers/uapi: Fix __BITS_PER_LONG value for x32 builds tip-bot for Ben Hutchings <tipbot@zytor.com> - 2015-10-02 09:50 +0200
csiph-web