Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1237417

Re: [PATCH] x86: uapi: Fix __BITS_PER_LONG for x32

From Brian Gerst <brgerst@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] x86: uapi: Fix __BITS_PER_LONG for x32
Date 2015-10-01 15:10 +0200
Message-ID <qeLMv-53B-33@gated-at.bofh.it> (permalink)
References <qeAel-4BU-3@gated-at.bofh.it> <qeHpx-6S6-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Oct 1, 2015 at 4:23 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Ben Hutchings <ben@decadent.org.uk> wrote:
>
>> diff --git a/arch/x86/include/uapi/asm/bitsperlong.h b/arch/x86/include/uapi/asm/bitsperlong.h
>> index b0ae1c4..217909b 100644
>> --- a/arch/x86/include/uapi/asm/bitsperlong.h
>> +++ b/arch/x86/include/uapi/asm/bitsperlong.h
>> @@ -1,7 +1,7 @@
>>  #ifndef __ASM_X86_BITSPERLONG_H
>>  #define __ASM_X86_BITSPERLONG_H
>>
>> -#ifdef __x86_64__
>> +#if defined(__x86_64__) && !defined(__ILP32__)
>>  # define __BITS_PER_LONG 64
>
> Can we write this as:
>
>    #ifdef __ILP64__

Do all versions of gcc/clang define that, even if x32 isn't supported?

--
Brian Gerst
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] x86: uapi: Fix __BITS_PER_LONG for x32 Ben Hutchings <ben@decadent.org.uk> - 2015-10-01 02:50 +0200
  Re: [PATCH] x86: uapi: Fix __BITS_PER_LONG for x32 Ingo Molnar <mingo@kernel.org> - 2015-10-01 10:30 +0200
    Re: [PATCH] x86: uapi: Fix __BITS_PER_LONG for x32 Brian Gerst <brgerst@gmail.com> - 2015-10-01 15:10 +0200
      Re: [PATCH] x86: uapi: Fix __BITS_PER_LONG for x32 Ben Hutchings <ben@decadent.org.uk> - 2015-10-01 23:00 +0200
        Re: [PATCH] x86: uapi: Fix __BITS_PER_LONG for x32 Ben Hutchings <ben@decadent.org.uk> - 2015-10-02 04:00 +0200
  [tip:x86/urgent] x86/headers/uapi:   Fix __BITS_PER_LONG value for x32 builds tip-bot for Ben Hutchings <tipbot@zytor.com> - 2015-10-02 09:50 +0200

csiph-web