Re: [PATCH v7 02/11] task_isolation: add initial support

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 02/11] task_isolation: add initial support
Date	2015-10-01 14:20 +0200
Message-ID	<qeL06-3Kc-7@gated-at.bofh.it> (permalink)
References	<qdNx0-23T-7@gated-at.bofh.it> <qeL06-3Kc-9@gated-at.bofh.it> <qeL06-3Kc-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 1 Oct 2015, Frederic Weisbecker wrote:
> On Mon, Sep 28, 2015 at 11:17:17AM -0400, Chris Metcalf wrote:
> > +
> > +	while (READ_ONCE(dev->next_event.tv64) != KTIME_MAX) {
> 
> You should add a function in tick-sched.c to get the next tick. This
> is supposed to be a private field.

Just to make it clear. Neither the above nor a similar check in
tick-sched.c is going to happen.

This busy waiting is just horrible. Get your act together and solve
the problems at the root and do not inflict your quick and dirty
'solutions' on us.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v7 02/11] task_isolation: add initial support Thomas Gleixner <tglx@linutronix.de> - 2015-10-01 14:20 +0200
  Re: [PATCH v7 02/11] task_isolation: add initial support Frederic Weisbecker <fweisbec@gmail.com> - 2015-10-01 14:30 +0200
    Re: [PATCH v7 02/11] task_isolation: add initial support Thomas Gleixner <tglx@linutronix.de> - 2015-10-01 14:40 +0200
  Re: [PATCH v7 02/11] task_isolation: add initial support Thomas Gleixner <tglx@linutronix.de> - 2015-10-01 23:30 +0200
    Re: [PATCH v7 02/11] task_isolation: add initial support Thomas Gleixner <tglx@linutronix.de> - 2015-10-02 21:10 +0200

csiph-web